This implements nsIGlobalHistory3 which includes AddToplevelRedirect. These redirects are stored in a queue along with their time. When a page is visited, we recursively check for redirects leading to this page and add them to history. The guts of the old InternalAdd got moved to AddVisit since I realized they were the same. Lots of the referring calculation code got moved around a bit and it makes much more sense. I also removed the index for the session ID since it's only used for initizalizing the list and will slow down all visit inserts (very common).

Comment on attachment 210922 [details] [diff] [review] Patch >+NS_INTERFACE_MAP_BEGIN(nsNavHistory) >+ NS_INTERFACE_MAP_ENTRY(nsINavHistoryService) >+ NS_INTERFACE_MAP_ENTRY_AMBIGUOUS(nsIGlobalHistory2, nsIGlobalHistory3) >+ NS_INTERFACE_MAP_ENTRY(nsIGlobalHistory3) >+ NS_INTERFACE_MAP_ENTRY(nsIBrowserHistory) >+ NS_INTERFACE_MAP_ENTRY(nsIObserver) >+ NS_INTERFACE_MAP_ENTRY(nsISupportsWeakReference) >+ NS_INTERFACE_MAP_ENTRY(nsIAutoCompleteSearch) >+ NS_INTERFACE_MAP_ENTRY_AMBIGUOUS(nsISupports, nsINavHistoryService) >+NS_INTERFACE_MAP_END I just noticed that you don't have nsIGlobalHistory (the original version) in the interface map. This seems like a problem. Looks ok otherwise.

The old history implementation doesn't implement nsIGlobalHistory either. It is marked deprecated.

On branch and trunk. Note: If you were using an old places build, redirects you visited in that build will not be hidden when you visit them again in this build. Once a page has been "unhidden" it is not hidden again and will always be shown, and the old build put redirect pages into history as unhidden. Clearing your history or deleting storage.sdb will reset this and the redirects will be hidden.

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv