Closed Bug 326011 Opened 19 years ago Closed 19 years ago

Scrollbars of iframe unusable after refresh, in this case

Categories

(Core :: Layout, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: martijn.martijn, Assigned: roc)

References

Details

(Keywords: regression, testcase)

Attachments

(2 files, 1 obsolete file)

See upcoming testcase.
You should be able to drag with the scrollbarthumb in the iframe.
This works in a 2006-01-25 build, but doesn't work anymore in a 2006-01-26 build.

The testcase consists of an onscroll event listener that changes the location of the iframe while scrolling. After that the scrollbar of the iframe seems to have become unusable to scroll with.
Attached file testcase (deleted) —
Attached patch fix (obsolete) (deleted) — Splinter Review
This is what happens:
-- IFRAME document scrollbar grabs the mouse
-- IFRAME gets reframed, scrollbar is destroyed, pushes the grab up to the nearest enclosing view that isn't destroyed: this is the nsSubDocumentFrame's inner view, which doesn't have a frame
-- mouse button released: the mouse event goes to presshell::HandleEvent, which sees there is no view and because it has dispatchUsingCoordinates, none of the cases fire and the event is lost --- capture is not released
-- future mouse events are captured by the inner view and lost in the same way

We need to do something with mouse events to views without frames. This patch redirects them to the nearest enclosing view with a frame.
Assignee: nobody → roc
Status: NEW → ASSIGNED
Attachment #210931 - Flags: superreview?(dbaron)
Attachment #210931 - Flags: review?(dbaron)
Comment on attachment 210931 [details] [diff] [review]
fix

Please merge this with the code right below that's doing the same thing for KEY and IME events instead.

(You'll be stuck with testing for (aEvent->message != NS_CONTEXTMENU_KEY && !NS_IS_FOCUS_EVENT(aEvent)) unless you want to change those too; the former doesn't scare me, but the latter does, a little.)
Attachment #210931 - Flags: superreview?(dbaron)
Attachment #210931 - Flags: superreview-
Attachment #210931 - Flags: review?(dbaron)
Attachment #210931 - Flags: review-
Attached patch updated patch (deleted) — Splinter Review
Updated to comments
Attachment #210931 - Attachment is obsolete: true
Attachment #212996 - Flags: superreview?
Attachment #212996 - Flags: review?
Attachment #212996 - Flags: superreview?(dbaron)
Attachment #212996 - Flags: superreview?
Attachment #212996 - Flags: review?(dbaron)
Attachment #212996 - Flags: review?
Attachment #212996 - Flags: superreview?(dbaron)
Attachment #212996 - Flags: superreview+
Attachment #212996 - Flags: review?(dbaron)
Attachment #212996 - Flags: review+
checked in
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Verified FIXED using build 2006-02-28-09 with SeaMonkey trunk on Windows XP.

Testcase: https://bugzilla.mozilla.org/attachment.cgi?id=210801&action=view
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: