Closed
Bug 327918
Opened 19 years ago
Closed 18 years ago
Setting role="wairole:application" dynamically is not successful
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
References
()
Details
(Keywords: access)
Attachments
(1 file)
(deleted),
patch
|
ginnchen+exoracle
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Go to http://www.mozilla.org/access/dhtml/class/checkbox
The role for the root document should be ROLE_APPLICATION, not ROLE_DOCUMENT.
Assignee | ||
Comment 1•19 years ago
|
||
There was a bug in the script. It appears to be working in my debug builds now but for some reason, not in official Firefox 1.5.
Comment 2•19 years ago
|
||
Still not working in Firefox 1.5.0.2
Assignee | ||
Updated•19 years ago
|
Blocks: fox2access
Assignee | ||
Comment 3•19 years ago
|
||
Appears to be a timing issues. It worked the first time when the image needed to be loaded, but not subsequent tries when the image was already cached.
Assignee | ||
Comment 4•19 years ago
|
||
This adds a small delay after domcontentloaded comes in, before creating an accessible for the document and using that accessible to fire an event.
This also changes document load (reorder) events under ATK so they can be fired before the images are finished loading. That's what we've been doing for MSAA. Is the change okay?
Attachment #219165 -
Flags: review?(ginn.chen)
Attachment #219165 -
Flags: review?(ginn.chen) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #219165 -
Flags: superreview?(roc)
What if the attribute is set dynamically after the page has loaded? Do you just not support that?
Assignee | ||
Comment 6•19 years ago
|
||
> What if the attribute is set dynamically after the page has loaded? Do you just
> not support that?
In that case we'll catch the attribute change via nsIDocumentObserver which is init'd by then. In the ::AttributeChanged() method we see the role change and we invalidate the cache at that point.
Attachment #219165 -
Flags: superreview?(roc) → superreview+
Assignee | ||
Comment 7•18 years ago
|
||
Hmm, this fix won't work for Firefox 2 (Gecko 1.8) because of the small API change in nsIAccessibleEvent.idl:
+ const unsigned long EVENT_INTERNAL_LOAD = 0xffff;
We can't have API changes in Gecko 1.8. I supposed I could try to put the constant in an nsPI private interface.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•