Closed
Bug 328150
Opened 19 years ago
Closed 19 years ago
move upload into xforms.xhtml
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
Details
(Keywords: fixed1.8.0.4, fixed1.8.1)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051212 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051212 Firefox/1.6a1
move upload into xforms.xhtml
Reproducible: Always
|
||
Updated•19 years ago
|
Assignee: aaronr → surkov
|
|
||
Updated•19 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #213223 -
Flags: review?(allan)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #213223 -
Flags: review?(doronr)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #213223 -
Flags: review?(doronr)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #213223 -
Flags: review?(doronr)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 213223 [details] [diff] [review]
patch
>-upload {
>- -moz-binding: url('chrome://xforms/content/xforms.xml#xformswidget-upload-disabled');
>+html|*:root upload {
>+ -moz-binding: url('chrome://xforms/content/xforms-xhtml.xml#xformswidget-upload-disabled');
> }
html|*:root, what is that?
|
|
Assignee | |
Comment 3•19 years ago
|
||
(In reply to comment #2)
>
> html|*:root, what is that?
>
It means the upload control will be used only in xhtml documents and we should provide new widgets for other documents (like xul, svg or something else).
|
|
||
Updated•19 years ago
|
Attachment #213223 -
Flags: review?(allan) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Attachment #213223 -
Attachment is obsolete: true
Attachment #215974 -
Flags: review?(doronr)
Attachment #213223 -
Flags: review?(doronr)
|
|
||
Comment 5•19 years ago
|
||
Comment on attachment 215974 [details] [diff] [review]
updated
>+ <handler event="keypress" keycode="VK_RETURN">
>+ switch (event.originalTarget.getAttribute("anonid")) {
>+ case "browse_button": case "clear_button":
>+ this.dispatchDOMUIEvent('DOMActivate');
>+ break;
>+ }
I prefer:
case "browse_button":
case "clear_button":
makes it more readable.
Attachment #215974 -
Flags: review?(doronr) → review+
|
|
Assignee | |
Comment 6•19 years ago
|
||
Attachment #215974 -
Attachment is obsolete: true
|
|
||
Comment 7•19 years ago
|
||
Checked into trunk
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
|
|
||
Updated•19 years ago
|
Keywords: fixed1.8.0.3,
fixed1.8.1
|
|
||
Updated•19 years ago
|
Whiteboard: xf-to-branch
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•