Closed
Bug 328407
Opened 19 years ago
Closed 19 years ago
configure and Makefile include .svn directories if run from inside a subversion repository
Categories
(Webtools Graveyard :: Tinderbox2, defect)
Webtools Graveyard
Tinderbox2
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bear, Assigned: bear)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
This bug is courtesy of John L. Villalovos and was sent to me via email.
His two patches allow the configure and Makefile script to handle excluding .svn directories if they are run from a Tinderbox2 subversion working directory.
I modified his patches in a minor fashion.
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #212994 -
Flags: review?
Attachment #212994 -
Flags: review? → review?(benjamin)
Comment 2•19 years ago
|
||
Comment on attachment 212994 [details] [diff] [review]
patch to exclude .svn files in configure and Makefile when they look for perl code
I don't own (or know anything about) tinderbox2. Bumping to timeless.
Attachment #212994 -
Flags: review?(benjamin) → review?(timeless)
Comment on attachment 212994 [details] [diff] [review]
patch to exclude .svn files in configure and Makefile when they look for perl code
for the record, i seem to recall actively complaining about this code. i wanted something that whitelisted stuff that made sense instead of blacklisting things that didn't make sense.
that said, if this is really only supposed to be about the second patched file, then i'd probably review+ just that patch.
Attachment #212994 -
Flags: review?(timeless) → review-
Assignee | ||
Comment 4•19 years ago
|
||
removed the Makefile bits from the patch as they don't apply to this bug
Attachment #212994 -
Attachment is obsolete: true
Attachment #222315 -
Flags: review?(timeless)
Attachment #222315 -
Flags: review?(timeless) → review+
Assignee | ||
Comment 5•19 years ago
|
||
patch applied in revision 1.25
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
QA Contact: kestes → tinderbox2
Updated•10 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•