This function is only used in process_bug.cgi, and people really ought to be using Bug objects to get this information anyhow. So we're moving the function to process_bug.cgi.

Once again, a very straightforward patch. Tested only for compilation.

Comment on attachment 213025 [details] [diff] [review] v1 >Index: process_bug.cgi >=================================================================== >+ my ($in_group) = Bugzilla->dbh->selectrow_array( >+ "SELECT CASE WHEN bug_id != 0 THEN 1 ELSE 0 END >+ FROM bug_group_map >+ WHERE bug_id = ? AND group_id = ?", undef, $bug_id, $group_id); Nit: Add parenthesis around $bug_id, $group_id parameters. Should be done on checkin.

Comment on attachment 213025 [details] [diff] [review] v1 >+sub BugInGroupId { >+ my ($bug_id, $group_id) = @_; >+ trick_taint($bug_id); >+ trick_taint($group_id); You should write detaint_natural() for both of them. Please fix that on checkin.

There was some minor, easily-fixed bitrot when I went to check in the patch, but I fixed it. Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.354; previous revision: 1.353 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.306; previous revision: 1.305 done

Here's what actually got checked in.