Closed
Bug 328449
Opened 19 years ago
Closed 19 years ago
Remove BugMail::MessageToMTA() from Bug::RemoveVotes()
Categories
(Bugzilla :: Email Notifications, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
RemoveVotes() is the only reason why Bugzilla::Bug uses Bugzilla::BugMail. This dependency doesn't make sense and Bug.pm should not send any email itself. So RemoveVotes() now returns to the caller an array of messages to send. This also allows us to send these emails outside a LOCK TABLES in process_bug.cgi.
|
Assignee | |
Comment 1•19 years ago
|
||
Tested successfully on 2.23, but should work on 2.22 too, if we want it on this branch.
Attachment #213037 -
Flags: review?(mkanat)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 213037 [details] [diff] [review]
patch, v1
This looks obviously correct, to me.
r=mkanat by inspection, provided that you've tested it.
Attachment #213037 -
Flags: review?(mkanat) → review+
|
|
||
Updated•19 years ago
|
Severity: normal → enhancement
Status: NEW → ASSIGNED
|
|
||
Updated•19 years ago
|
Flags: approval?
|
||
Updated•19 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v <-- editproducts.cgi
new revision: 1.112; previous revision: 1.111
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi
new revision: 1.304; previous revision: 1.303
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm
new revision: 1.109; previous revision: 1.108
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•