Max Kanat-Alexander Assignee
	Description • 19 years ago

These two variables are related together in the creation of versioncache, so we're going to eliminate them together.

	Max Kanat-Alexander Assignee
	Comment 1 • 19 years ago

As you can see, this allowed a huge cleanup, particularly in query.cgi.

There were a few places where I also changed the use of %::components and %::milestones, because it was necessary to change the way the script worked.

I tested every single change, they all work.

	Frédéric Buclin
	Comment 2 • 19 years ago

Comment on attachment 213203 [details] [diff] [review]
v1

>Index: buglist.cgi

You forgot to remove @versions from 'use vars'.



>Index: post_bug.cgi

>@@ -79,6 +79,7 @@
> # is allowed to enter bugs into this product.
> my $product = $cgi->param('product');
> $user->can_enter_product($product, 1);
>+my $prod_obj = new Bugzilla::Product({name => $product});
> 
> my $product_id = get_product_id($product);

Please write $product_id = $prod_obj->id. This avoid a useless SQL query.


>@@ -203,7 +204,8 @@
>-check_form_field($cgi, 'version',          $::versions{$product});
>+check_form_field($cgi, 'version',      
>+                 [map($_->name, @{$prod_obj->versions})]);

check_form_field() no longer exists. It has been replaced by check_field() and doesn't take a CGI object anymore.



>Index: process_bug.cgi

>-    check_form_field($cgi, 'version', \@{$::versions{$cgi->param('product')}});
>+    check_form_field($cgi, 'version', [map($_->name, @{$prod_obj->versions})]);

Same remark here.


Your patch *looks* good. I haven't tested it yet though, due to bitrot.

	Max Kanat-Alexander Assignee
	Comment 3 • 19 years ago

Good comments. :-) I fixed them all.

	Frédéric Buclin
	Comment 4 • 19 years ago

Comment on attachment 213551 [details] [diff] [review]
v2

I cannot correctly test your patch, because you forgot to fix Bug.pm:

line 25: %versions appears in 'use vars'

line 689: 'version' => $::versions{$self->{product}},


And you still forgot to remove %versions from 'use vars' in process_bug.cgi.

Same about $zz = @main::legal_versions; in globals.pl.

	Max Kanat-Alexander Assignee
	Comment 5 • 19 years ago

Ah, you are correct. Fixed and tested.

	Frédéric Buclin
	Comment 6 • 19 years ago

Comment on attachment 213636 [details] [diff] [review]
v3

>Index: Bugzilla/Bug.pm

>+    $self->{prod_obj} ||= new Bugzilla::Product({name => $self->{product}});

>+       'version' => [map($_->name, @{$self->{prod_obj}->versions})],

Nit: personally, I prefer enclosing things in quotes, for instance $self->{'prod_obj'}.

r=LpSolit

	Max Kanat-Alexander Assignee
	Comment 7 • 19 years ago

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.326; previous revision: 1.325
done
Checking in config.cgi;
/cvsroot/mozilla/webtools/bugzilla/config.cgi,v  <--  config.cgi
new revision: 1.15; previous revision: 1.14
done
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.129; previous revision: 1.128
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.355; previous revision: 1.354
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.138; previous revision: 1.137
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.307; previous revision: 1.306
done
Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.156; previous revision: 1.155
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.111; previous revision: 1.110
done
Checking in Bugzilla/Version.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Version.pm,v  <--  Version.pm
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/search/form.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v <--  form.html.tmpl
new revision: 1.36; previous revision: 1.35
done