Open Bug 329649 Opened 19 years ago Updated 4 years ago

Use colors in request.cgi to indicate bug severity

Categories

(Bugzilla :: User Interface, enhancement)

2.23
enhancement
Not set
normal

Tracking

()

People

(Reporter: LpSolit, Unassigned)

References

(Depends on 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

Using colors to indicate bug severity will help in triaging reviews too. I will also make some small cleanup.
Attached patch patch, v1 (obsolete) (deleted) — Splinter Review
I also did some cleanup/small UI improvement: - I now use only one table (so that all columns look aligned => nicer UI) - I added labels to the form - I let you discover what I changed too... ;)
Attachment #214344 - Flags: review?(wurblzap)
Attached patch patch, v2 (obsolete) (deleted) — Splinter Review
This patch is really what I wanted and look nice IMO. But myk doesn't like the use of background colors to indicate either severities or priorities. I post my patch here because I wrote it. But I won't insist any longer.
Attachment #214344 - Attachment is obsolete: true
Attachment #214462 - Flags: review?
Attachment #214344 - Flags: review?(wurblzap)
/me gives up
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WONTFIX
Target Milestone: Bugzilla 2.24 → ---
Comment on attachment 214462 [details] [diff] [review] patch, v2 /me said I give up
Attachment #214462 - Flags: review?
Would it not be worht doing what buglist.cgi does to a certain extent, bold red for blockers etc.?
myk doesn't like it, but justdave seems more receptive to this UI. Let's see...
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Target Milestone: --- → Bugzilla 2.24
(In reply to comment #6) > Would it not be worht doing what buglist.cgi does to a certain extent, bold red > for blockers etc.? > Looks ugly (that's what I did initially), because there are two URLs in this table, one for bugs, and one for attachments. Using background colors is much nicer IMO.
Status: REOPENED → ASSIGNED
Attachment #214462 - Flags: review?(wurblzap)
Attached patch patch, v2.1 (deleted) — Splinter Review
unbitrotten patch.
Attachment #214462 - Attachment is obsolete: true
Attachment #214799 - Flags: review?(wurblzap)
Attachment #214462 - Flags: review?(wurblzap)
Attachment #214799 - Flags: review?(bugzilla)
Comment on attachment 214799 [details] [diff] [review] patch, v2.1 Just to check I understand correctly, a changes Summary: - Add status search - Add order search - center grouping type table title - add days since in created data column - prefix priority to bug title when sorting by priority - prefix severity to bug title when sorting by severity - color bug title column when sorting by severity - color date column when sorting by date Reasons for r- 1) Don't like the (P1-) and (Sev-) prefixes. Probably not needed. But I could maybe live with appending them, maybe after a <br> 2) Gap above the 'Group By' and 'Sort By' row should not be there. 3) No (obvious to me) indication of flag status. Needed when searching for 'All' or '+-' 4) bz_bimonth should be better: bz_months? 5) Should apply styles to whole row (in case people want to highlight the whole row) 6) I think that CSS validators say you should explictly set foreground color and background-color together 7) No newline at end of requests.css 8) Is the license for requests.cgi correct? - it says netscape developed it first? 9) 'center' is a bad css name, isn't it? (in: <div class="center">N/A</div>) 10 bz_month == 21 days??? For Extra Points (while you are changing other stuff :) - Shouldn't we share the severity css colors with buglist.css somehow? - Sort by: Bug Id? - Group by: None - show count of total requests and count per grouped table (alongside the title for each table) - Add a view-as-buglist link for each grouped table
Attachment #214799 - Flags: review?(bugzilla) → review-
Comment on attachment 214799 [details] [diff] [review] patch, v2.1 Is colouring really what we want? I think what we want is some way of ordering the list.
Attachment #214799 - Flags: review?(wurblzap)
(In reply to comment #11) > Is colouring really what we want? > > I think what we want is some way of ordering the list. Marc, don't you like my marvelous screenshot? :) Honestly, I don't want to waste my time on this bug if that's not something we want.
I like the screenshot and the concept, but I'd rather see this as a skin (or part of a skin). But don't let my personal opinion get in other's way :)
(In reply to comment #13) > I like the screenshot and the concept, but I'd rather see this as a skin (or > part of a skin). Hum... or a checkbox "use colors for the sort order key" for those who do/don't want to see colors?
I quite like colors as an easy way to indicate priority or importance, so I'm OK with the colors. If an approver doesn't like the colors, then we can just remove those few bits from the new CSS, yes?
I don't have time to play with this bug before 3.0
Assignee: LpSolit → ui
Status: ASSIGNED → NEW
Target Milestone: Bugzilla 3.0 → ---
The sort order thing is bug 179522.
Depends on: 179522
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: