Closed Bug 330263 Opened 19 years ago Closed 19 years ago

Off-by-one error in Places drag and drop

Categories

(Firefox :: Bookmarks & History, defect, P2)

x86
Windows XP
defect

Tracking

()

RESOLVED FIXED
Firefox 2 alpha2

People

(Reporter: me, Assigned: bugs)

Details

(Whiteboard: swag: 2d)

Attachments

(1 file)

Oops! Anyway, if you try to drag a bookmark to a position below its current place it will move down one too far, it seems like its counting itself when it shouldn't. Steps to Reproduce: 1. Open Bookmarks->Organize Bookmarks. 2. In the Places window find a bookmarks folder that has at least 3-4 entries. 3. Drag the top bookmark below the second bookmark. Actual Results: The dragged bookmark ends up as the third one down. Expected Results: The dragged bookmark should end up as the second one down.
Confirming my own bug (sorry, the unguided new bug form is my nemesis).
Status: UNCONFIRMED → NEW
Ever confirmed: true
I see the same in the bookmarks-menu and bookmarks toolbar folder and all sub-folders; not only in the Places view. It only goes wrong when you drag downwards, not upwards.
Assignee: nobody → bugs
Priority: -- → P2
Target Milestone: --- → Firefox 2 alpha2
Whiteboard: swag: 2d
Attached patch patch (deleted) — Splinter Review
Changes the d&d code to locate a node within a folder by using the current result, not a new one. (walk the hierarchy of the current tree, rather than executing a new query by calling getFolderContents)
Attachment #216855 - Flags: review?(brettw)
Attachment #216855 - Flags: review?(brettw) → review+
fixed branch and trunk
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: