User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060315 Firefox/1.6a1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060315 Firefox/1.6a1 This surfaces with XForms 1.0 test suite test cases 4.3.8.a and 4.6.5.a Aaron says... The problem appears to be that we can't pop up mutliple messages at the same time. On 4.6.5.a I can actually see the message in the window change from xforms-submit to xforms-submit-error without popping up a new window. Yet we are requesting a new window in xforms, so I don't know what mozilla is doing wrong under the covers. The events are being fired properly, btw. Reproducible: Always Steps to Reproduce: 1. Load test case 2. read what is expected behavior 3. observe the expected dialogs

The 2nd argument is the window name (http://landfill.mozilla.org/mxr-test/mozilla/source/dom/public/idl/base/nsIDOMWindowInternal.idl#162) - if a window with that name exists, it gets reused. So rather, use "_blank", which will always open a new window.

Comment on attachment 215432 [details] [diff] [review] patch >Index: extensions/xforms/nsXFormsMessageElement.cpp >=================================================================== >RCS file: /cvsroot/mozilla/extensions/xforms/nsXFormsMessageElement.cpp,v >retrieving revision 1.14 >diff -u -r1.14 nsXFormsMessageElement.cpp >--- extensions/xforms/nsXFormsMessageElement.cpp 13 Dec 2005 21:19:58 -0000 1.14 >+++ extensions/xforms/nsXFormsMessageElement.cpp 17 Mar 2006 20:30:47 -0000 >@@ -705,7 +705,7 @@ > > //XXX Add support for xforms-link-error. > nsCOMPtr<nsIDOMWindow> messageWindow; >- internal->OpenDialog(src, aLevel, options, arg, getter_AddRefs(messageWindow)); >+ internal->OpenDialog(src, NS_LITERAL_STRING("_blank"), options, arg, getter_AddRefs(messageWindow)); > if (!isModal) { > nsCOMPtr<nsIDOMWindowInternal> msgWinInternal = > do_QueryInterface(messageWindow); nits: please add a comment as to why you are passing in _blank as the name. It isn't immediately apparent. Also please wrap the parameter so that we don't extend over 80 chars. With those r=me.

Comment on attachment 215432 [details] [diff] [review] patch r=me with the same nits as Aaron

fixed on trunk