Closed Bug 330698 Opened 19 years ago Closed 19 years ago

Remove $::components, @::enterable_products and $::classifications

Categories

(Bugzilla :: Bugzilla-General, enhancement)

2.23
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

Attachments

(1 file, 1 obsolete file)

$::components appears in many places, but $product->components will probably fix it. I will kill @::enterable_products too which appears in one place only. And $::classifications is not used at all, so its removal will be straightforward. :)
Attached patch patch, v1 (obsolete) (deleted) — Splinter Review
OK, I have heavily tested my patch and I think I found all regressions. :)
Attachment #215345 - Flags: review?(mkanat)
Comment on attachment 215345 [details] [diff] [review]
patch, v1

r=mkanat by inspection. I trust LpSolit's testing.

We should file another bug to make Bugzilla::Bug->product always be an object instead of just the name of the product.
Attachment #215345 - Flags: review?(mkanat) → review+
Attached patch patch, v1.1 (deleted) — Splinter Review
unbitrotten.
Attachment #215345 - Attachment is obsolete: true
Attachment #216966 - Flags: review?(mkanat)
Comment on attachment 216966 [details] [diff] [review]
patch, v1.1

carrying forward mkanat's r+. The bitrot was trivial to fix.
Attachment #216966 - Flags: review?(mkanat) → review+
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+
Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.331; previous revision: 1.330
done
Checking in duplicates.cgi;
/cvsroot/mozilla/webtools/bugzilla/duplicates.cgi,v  <--  duplicates.cgi
new revision: 1.52; previous revision: 1.51
done
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.132; previous revision: 1.131
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.361; previous revision: 1.360
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.141; previous revision: 1.140
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.312; previous revision: 1.311
done
Checking in reports.cgi;
/cvsroot/mozilla/webtools/bugzilla/reports.cgi,v  <--  reports.cgi
new revision: 1.81; previous revision: 1.80
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.114; previous revision: 1.113
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: