Among several other patches, this fix was proposed by Chris Seawood in Bug 328499, Comment 34. I move this fix to a new bug, such that it can be implemented independent of other discussions in that bug.

If this patch is accepted, please check it in as well. (I do not have CVS write access.)

Comment on attachment 215845 [details] [diff] [review] use dllexport in cairo_public for all XP_WIN platforms (part of cls' patch) we can't use XP_WIN in cairo code (as we want to push all patches upstream). This needs to have some other ifdef for mingw.

Thank you for your quick response! Sorry about my ignorance, but it seems to me that using XP_WIN should be o.k. in cairo-platform.h, given that a) cairo-platform.h seems to be only in mozilla, but not in the official cairo tree, http://lxr.mozilla.org/mozilla/source/gfx/cairo/cairo/src/ http://gitweb.freedesktop.org/?p=cairo;a=tree;f=src b) cairo-plaform.h also uses XP_BEOS, XP_MAC, XP_OS2_VACPP. http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/gfx/cairo/cairo/src/cairo-platform.h&rev=1.1&mark=47,54,61#37 It would be very helpful, if you could elaborate somewhat more on your point. Would #if defined(_MSC_VER) || defined(XP_WIN) be a better solution?

Comment on attachment 215845 [details] [diff] [review] use dllexport in cairo_public for all XP_WIN platforms (part of cls' patch) hmm, thats fair

do you need me to check stuff in for you?

Yes, that would be great! (I do not have CVS write access.) Please check in the patches for https://bugzilla.mozilla.org/buglist.cgi?bug_id=331287,331329,331333.

Er, no; this patch isn't acceptable -- XP_WIN is a mozilla-only define, where cairo-platform.h is a cairo include file. The preprocessor directive should be changed to #if defined(_MSC_VER) || defined(SOMETHING_THAT_MINGW_DEFINES). If someone can let me know what SOMETHING_THAT_MINGW_DEFINES is, I'll fix this.

Blah, ignore me, we never got around to pushing cairo-platform.h upstream