Closed
Bug 331487
Opened 19 years ago
Closed 17 years ago
Fix GROUP_BY_FOLDER in query system
Categories
(Firefox :: Bookmarks & History, defect, P3)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
INVALID
People
(Reporter: brettw, Assigned: ondrej)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
The current query system doesn't do anything with GROUP_BY_FOLDER. It just assumes for bookmark queries that you want folders, and for history queries you don't. The only thing this option would help is for nested tags if you want all items in the folder and it's descendents to appear in a flat list. Apparently we aren't supporting this, so we can remove this flag.
Reporter | ||
Updated•19 years ago
|
Priority: -- → P2
Target Milestone: --- → Firefox 2 alpha2
Updated•19 years ago
|
Target Milestone: Firefox 2 alpha2 → Firefox 2 beta1
Comment 1•19 years ago
|
||
This doesn't work, but is a straw man of a group by folder impl.
Updated•19 years ago
|
Summary: Remove GROUP_BY_FOLDER from query system → Fix GROUP_BY_FOLDER from query system
Whiteboard: swag: 0d (part of 317830) → swag: ???d
Reporter | ||
Comment 2•19 years ago
|
||
Note: we should also make sure using multiple folders in the query gives the same results.
Reporter | ||
Updated•18 years ago
|
Priority: P2 → P3
Summary: Fix GROUP_BY_FOLDER from query system → Fix GROUP_BY_FOLDER in query system
Whiteboard: swag: ???d → swag: 2d
Target Milestone: Firefox 2 beta1 → Firefox 3 alpha2
Reporter | ||
Updated•18 years ago
|
Assignee: brettw → nobody
Comment 3•17 years ago
|
||
should resolve this asap, before B1 which is likely when extension developers will really start to flex this stuff.
No longer depends on: 317830
Target Milestone: Firefox 3 alpha2 → Firefox 3 alpha6
Updated•17 years ago
|
Whiteboard: swag: 2d
Updated•17 years ago
|
Target Milestone: Firefox 3 alpha6 → Firefox 3 beta1
Updated•17 years ago
|
Target Milestone: Firefox 3 M7 → Firefox 3 M8
Comment 4•17 years ago
|
||
making this a tracker for the other GROUP_BY_FOLDER bugs.
Updated•17 years ago
|
Target Milestone: Firefox 3 M8 → Firefox 3 M9
Updated•17 years ago
|
Target Milestone: Firefox 3 M9 → Firefox 3 M10
Comment 5•17 years ago
|
||
B1 is out, and still not fixed. In my extension i need to recursively get all folders as i want to show all bookmarks in a flat list. It would be nice, if this wouldn't be needed.
Updated•17 years ago
|
Target Milestone: Firefox 3 M10 → Firefox 3 M11
Assignee | ||
Comment 6•17 years ago
|
||
I just want to remind that with bug 385245 all the other groupings will be removed (if patch gets approved). I have now checked that GROUP_BY_FOLDER is only used for the "Recent Tags" query in "Smart Bookmarks". So I will try to remove the last grouping using the mentioned bug.
Assignee | ||
Comment 7•17 years ago
|
||
Bug 385245 has been finished and is waiting for review. Grouping was completely replaced with queries.
Assignee: nobody → ondrej
Depends on: 385245
Updated•17 years ago
|
Target Milestone: Firefox 3 beta3 → ---
Assignee | ||
Comment 8•17 years ago
|
||
GROUP_BY_FOLDER has gone with bug 385245, the bug is invalid now.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → INVALID
Comment 9•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•