Closed
Bug 332037
Opened 19 years ago
Closed 19 years ago
Make Sunbird built with MOZ_DEBUG=1 be more obvious
Categories
(Calendar :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mattwillis, Assigned: mattwillis)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mvl
:
first-review+
|
Details | Diff | Splinter Review |
A Sunbird built with MOZ_DEBUG=1 looks no different than one without. It would be good to make it more obvious that debug is enabled. Ff and Tb both do this.
Assignee | ||
Comment 1•19 years ago
|
||
dmose thought this wasn't a bad idea.
Attachment #216582 -
Flags: first-review?(jminta)
Comment 2•19 years ago
|
||
Comment on attachment 216582 [details] [diff] [review]
rev0 - changes app name to "SunbirdDebug" for builds with debug enabled
I'm not qualified to review makefile stuff, over to mvl.
Attachment #216582 -
Flags: first-review?(jminta) → first-review?(mvl)
Assignee | ||
Comment 3•19 years ago
|
||
I was trying to make too many changes to this Makefile at once but keep the patches relevant to only one bug, and I forgot the sed line.
Attachment #216582 -
Attachment is obsolete: true
Attachment #216585 -
Flags: first-review?
Attachment #216582 -
Flags: first-review?(mvl)
Assignee | ||
Updated•19 years ago
|
Attachment #216585 -
Flags: first-review? → first-review?(mvl)
Comment 4•19 years ago
|
||
Comment on attachment 216585 [details] [diff] [review]
rev1 - forgot this part
This part looks good, but it seems that you missed changing Info.plist.in to actually contain APP_NAME instead of the hard-coded Sunbird. Otherwise i don't see the use of the sed.
Attachment #216585 -
Flags: first-review?(mvl) → first-review+
Assignee | ||
Comment 5•19 years ago
|
||
(In reply to comment #4)
> (From update of attachment 216585 [details] [diff] [review] [edit])
> This part looks good, but it seems that you missed changing Info.plist.in to
> actually contain APP_NAME instead of the hard-coded Sunbird.
You're right. I missed diffing Info.plist.in when I made the patch.
rev1 checked in with that change to trunk and 1.8
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•