Closed
Bug 332072
Opened 19 years ago
Closed 19 years ago
Fixup submission cosmetics
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: allan, Assigned: allan)
References
()
Details
(Keywords: fixed1.8.0.4, fixed1.8.1)
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
doronr
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•19 years ago
|
||
Fix submission header as smaug suggested... purely cosmetics. And no, I am not going to fix the string parameters, etc.
|
||
Comment 2•19 years ago
|
||
Comment on attachment 216615 [details] [diff] [review]
Patch
Hmm, now that you're fixing cosmetics, you could make sure that parameters are in form aParameter
+ NS_HIDDEN_(nsresult) SerializeData(nsIDOMNode *data, nsCString &uri,
+ nsIInputStream **, nsCString &contentType);
This looks especially strange
|
|
Assignee | |
Comment 3•19 years ago
|
||
(In reply to comment #2)
> (From update of attachment 216615 [details] [diff] [review] [edit])
> Hmm, now that you're fixing cosmetics, you could make sure that parameters are
> in form aParameter
>
> + NS_HIDDEN_(nsresult) SerializeData(nsIDOMNode *data, nsCString &uri,
> + nsIInputStream **, nsCString
> &contentType);
> This looks especially strange
Please see comment 1 ...
|
|
||
Updated•19 years ago
|
Attachment #216615 -
Flags: review?(smaug) → review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #216615 -
Flags: review?(doronr)
|
||
Updated•19 years ago
|
Attachment #216615 -
Flags: review?(doronr) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Checked into trunk
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
|
|
Assignee | |
Updated•19 years ago
|
Keywords: fixed1.8.0.3,
fixed1.8.1
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: xf-to-branch
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•