cpratt Reporter
	Description • 26 years ago

Sample HTML code:

<isindex prompt="Enter your search phrase: ">

This should create a single-line text input control. However, nothing happens in
seamonkey (feb-25 build). If the prompt attribute is used, you should see the
text of the prompt attribute. If no prompt attribute is used, you should see the
default "This is

	cpratt Reporter
	Comment 1 • 26 years ago

The default text displayed is "This is a searchable index. Enter search
keywords:".

	Eric Pollmann Assignee
	Comment 2 • 26 years ago

This is deprecated in HTML 4 but it's still in the spec.
Chris, any ideas on how we should be handling this?  Should a text input frame
be constructed for it?

	Eric Pollmann Assignee
	Comment 3 • 26 years ago

From the HTML 4 spec.  Should we handle this as we do the file input frame?

DEPRECATED EXAMPLE:
 The following ISINDEX declaration:

   <ISINDEX prompt="Enter your search phrase: ">

 could be rewritten with INPUT as follows:

   <FORM action="..." method="post">
   <P>Enter your search phrase: <INPUT type="text"></P>
   </FORM>

	karnaze (gone)
	Comment 4 • 26 years ago

I think you have the right idea. The important thing is to not create content
that doesn't belong in the content model. Most of this needs to happen on the
frame side.

	Eric Pollmann Assignee
	Comment 5 • 25 years ago

Redistributing bugs...

	Mats Palmgren (inactive)
	Comment 7 • 25 years ago

*** Bug 12879 has been marked as a duplicate of this bug. ***

	Eric Pollmann Assignee
	Comment 8 • 25 years ago

Since this is deprecated, I'm pushing it out unless I hear too many screams.

	Eric Pollmann Assignee
	Comment 9 • 25 years ago

After careful consideration, I've decided that I probably won't get this bug in
for M12.  Currently I have nearly 50 bugs scheduled for M13, so there is a
possibility that this bug may need to be moved out farther still.

	ekrock's old account (dead)
	Comment 10 • 25 years ago

Marking [4.xP]. Moving to M17. It's been deprecated but it may be used in old
forms so we should try to fix this before FCS if possible.

	ekrock's old account (dead)
	Comment 11 • 25 years ago

Bulk moving [testcase] code to new testcase keyword. Sorry for the spam!

	leger
	Comment 12 • 25 years ago

Setting the keyword all open [4.xp] bugs to 4xp.

	leger
	Comment 13 • 25 years ago

Putting on PDT- radar for beta1.  Will not hold beta for this bug.

	Eric Pollmann Assignee
	Comment 14 • 25 years ago

See bug 21265.  IsIndex content needs to implement nsIFormControl and
nsHTMLContentSink needs to call SetForm on the IsIndex when this gets
implemented.

	Asa Dotzler [:asa]
	Comment 15 • 25 years ago

*** Bug 30231 has been marked as a duplicate of this bug. ***

	Jan Carpenter
	Comment 16 • 25 years ago

cpratt is no longer in our group, changing qa contact to chrisd 

	Eric Pollmann Assignee
	Comment 17 • 25 years ago

Lowering priority, as this is not critical in relation to some of my other bugs.

 1) major regressions
 2) development blockers
 3) crashers and major usability issues
 4) cosmetic issues and standards compliance issues

This falls in category 4 and both deprecated and infrequently used.  Moving off
to M19.

	francis+moz
	Comment 18 • 25 years ago

This bug seems to have been duplicated (and fixed) as #33881.

	David Baron :dbaron:
	Comment 19 • 25 years ago

That bug looks different.  Did you test that it was fixed?

	Eric Pollmann Assignee
	Comment 20 • 25 years ago

Yeah, that's a separate issue.  Our implementation of the DOM interface does not
in imply that we are creating the correct kinds of frames for these elements
(and displaying them).

	Chris Petersen
	Comment 21 • 25 years ago

Added keyword nsbeta2.

	Jesse Ruderman
	Comment 22 • 25 years ago

*** Bug 38428 has been marked as a duplicate of this bug. ***

	leger
	Comment 23 • 25 years ago

Putting on [nsbeta2-] radar. Not critical to beta2.  Per kmcclusk call into PDT.

	Jesse Ruderman
	Comment 24 • 24 years ago

*** Bug 40744 has been marked as a duplicate of this bug. ***

	Phil Peterson
	Comment 25 • 24 years ago

Nominate for nsbeta3. This bug blocks the Internet Draft search page I've been 
using (http://info.internet.isi.edu/7c/in-drafts/.cach), so I have to use 4.x to 
search for I-Ds :-(  

	Eric Pollmann Assignee
	Comment 26 • 24 years ago

1/2 done, I got isindex to display correctly.  Now to get it to submit on Enter.  
:)

	Eric Pollmann Assignee
	Comment 27 • 24 years ago

My implementation displays like:

<HR>
(internationalized prompt string)[text input]
<HR>

The spec does not clearly state what the display should be, but this is how both 
IE and Nav display it.  (Note the box in the spec describing an alternative is 
not a suggestion on how to display isindex, but an example of an alternative 
that can be used to remove it from your web pages because it is deprecated)

Also note that this is not a standard form element and will not be submitted 
with the form if it is enclosed in a form (in fact, it is not displayed if in a 
form in Nav and IE).  Also, the value of the isindex is not submitted with a 
name.  That is, instead of http://foo.com/test.cgi?name=value it will be 
submitted as http://foo.com/test.cgi?value  Also, it can only be sent as a GET 
request and not a post.

Because of the above, I will not be reusing the logic in nsFormFrame to do the 
actual submit, but will be creating new logic.

	Eric Pollmann Assignee
	Comment 28 • 24 years ago

It's submitting now too, just need to work out one crasher I keep seeing...

	Eric Pollmann Assignee
	Comment 29 • 24 years ago

Got rid of the crash, ready to check in!  :)

	Kevin McCluskey (gone)
	Comment 30 • 24 years ago

Marking nsbeta3+

	Blake Ross
	Comment 31 • 24 years ago

fix checked in (by eric)

	Eric Pollmann Assignee
	Comment 32 • 24 years ago

This fix is not completely checked in yet, more coming tomorrow.  The partial 
checkin was to allow me to test on Mac before commiting the fix.

	Eric Pollmann Assignee
	Comment 34 • 24 years ago

href (action) and target are not part of the spec - see:

http://www.w3.org/TR/REC-html40/interact/forms.html#edef-ISINDEX

Therefore, I have not implemented them (yet).  If these are desirable, please
open a new bug on them - though it may be marked Future.

	Eric Pollmann Assignee
	Comment 35 • 24 years ago

Same crash as before - reappeared after Rod added some (valid and good) changes 
to nsHTMLInputElement.cpp.  It seems like the IsIndex frame or one of it's 
children is being destroyed when leaving the page, then after that, a blur event 
is being sent to the content.

Both new places in nsHTMLInputElement::HandleDOMEvent that call GetPrimaryFrame 
on this code path are getting back non-null for the frame pointer, but the frame 
itself is gone and null'd out -> crash when dereferencing in QueryInterface.

I came up with a hack-workaround for one of the new crashes, but the most 
recent, I can't figure out...  Will have to solve the underlying problem....

	rods (gone)
	Comment 36 • 24 years ago

*** Bug 48183 has been marked as a duplicate of this bug. ***

	ekrock's old account (dead)
	Comment 37 • 24 years ago

petersen, with marcell@netscape.com currently on vacation, is there any chance 
QA could use the top 100 crawler he wrote to scan top 100 sites & see if this is 
used? leger knows about this tool if you haven't heard about it already.

What we need is a quantitative assessment of how common ISINDEX is on the web. I 
have no idea. Unfortunately I suspect it's out there. However, content 
developers can work around this by conditionally generating either the ISINDEX 
for older browsers or the workaround HTML markup above for Netscape 6 (or just 
dropping the use of ISINDEX completely).

Bottom line: unless we find popular sites using this, I'll agree with Future-ing 
the bug.

	Chris Petersen
	Comment 38 • 24 years ago

I checked on the first 25 sites of our top 100 for isindex. I wasn't able to find 
it in use.

	Stephen Walker
	Comment 39 • 24 years ago

*** Bug 50226 has been marked as a duplicate of this bug. ***

	Kevin McCluskey (gone)
	Comment 40 • 24 years ago

Setting priority to P3 according to new criteria

	Eric Pollmann Assignee
	Comment 42 • 24 years ago

Fix is in.  To verify, go to the above test case marked "a test case".  This
should display as a horizontal line, followed by a text prompt reading "Search
for: " followed by a text input field.  Below this should be another horizontal
line.  Typing something into the text field and pressing Enter should submit the
page to the server (same URI that it came from) with a query string after it
that is equal to the string you typed in.

	Eric Pollmann Assignee
	Comment 43 • 24 years ago

Marking fixed...

	Chris Petersen
	Comment 44 • 24 years ago

Element is now rendered. Fixed in the Sept 14 build.

	Laurent RINEAU
	Comment 45 • 24 years ago

Why is there horizontal lines?

	Eric Pollmann Assignee
	Comment 46 • 24 years ago

The horizontal rules are there because that is what Nav and IE have done since
the beginning of time (as time is measured by isindex anyway ;)  Since this is a
deprecated tag, I tried to make it as fully backwards compatible as possible.  

(Admittedly it doesn't do a few things the Nav and IE do, but for most purposes
it looks the same)

	Laurent RINEAU
	Comment 47 • 24 years ago

OK, you're right. But, speaking about backward compatibility, Nav doesn't do the
same as Mozilla on the second testcase (which as a link around the ISINDEX
element). I am undex linux (build 2000091721) so I can't try with IE.

	Eric Pollmann Assignee
	Comment 48 • 24 years ago

Yes, that's one of those "few things the Nav and IE do" that aren't supported
yet.  Also I think IE supports a TARGET attribute (not part of the spec) that we
don't support yet.  It would be worthwhile to file a feature request bug on
these features - particularly if you (anyone) have pages that use them.  The two
"real" test cases I've seen on the web were very simple and our implementation
worked for them.

	neil@parkwaycc.co.uk
	Comment 49 • 24 years ago

OK, I'll file a feature request for href and target.

	karnaze (gone)
	Comment 50 • 24 years ago

Removing myself from CC list.

	Sivakiran Tummala
	Comment 51 • 23 years ago

are we not supporting this anymore...because it returns undefined when i use the
following code

<form id="form1">
<isindex prompt="booya">
</form>
<SCRIPT type="text/javascript">
	 document.write(document.getElementsByTagName("ISINDEX").prompt);

</SCRIPT>

	cpratt Reporter
	Comment 52 • 23 years ago

I *believe* that's invalid HTML. IIRC you can't stick an ISINDEX tag inside a 
FORM element...

	Sivakiran Tummala
	Comment 53 • 23 years ago

even does not work

	cpratt Reporter
	Comment 54 • 23 years ago

<isindex prompt="booya">
<SCRIPT type="text/javascript">
document.write(document.getElementsByTagName("ISINDEX").prompt);
</SCRIPT>

The above HTML snippet shows the TEXTAREA correctly but returns "" in 
Communicator 4.78 and "undefined" in IE 5.5. The TEXTAREA tag displays correctly 
 in Mozilla, so I'm going to close this back out again as FIXED (the original 
point of this bug was of course to implement TEXTAREA in the first place). If 
there's something wrong with the js event, please open a new bug. Thanks!

	Chris Petersen
	Comment 55 • 23 years ago

Marking verified per last comments.