Closed
Bug 332785
Opened 19 years ago
Closed 18 years ago
[Mac] Use bundle name instead of (empty) filename for helper apps
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: philor, Assigned: philor)
References
()
Details
(Keywords: fixed1.8.1)
Attachments
(3 files, 1 obsolete file)
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
(deleted),
application/hard-cheese
|
Details |
Once we get a getBundleName from bug 332784, View & Edit Actions needs to use it for helper app names #ifdef XP_MACOSX, instead of displaying "Open with ".
Assignee | ||
Updated•18 years ago
|
Assignee: philringnalda → bugs
Assignee | ||
Comment 1•18 years ago
|
||
Fixed in bug 337474
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 2•18 years ago
|
||
Gah, what was I thinking, deciding it was fixed for my problem without actually testing, or looking at which copies of that copied-around code were and weren't getting changed?
Assignee | ||
Updated•18 years ago
|
Assignee: bugs → philringnalda
Status: REOPENED → NEW
Target Milestone: --- → Firefox 2
Version: Trunk → 2.0 Branch
Assignee | ||
Comment 3•18 years ago
|
||
Attachment #235357 -
Flags: review?(bugs.mano)
Assignee | ||
Comment 4•18 years ago
|
||
Comment on attachment 235357 [details] [diff] [review]
Trunk patch
Oops, if you're going to copy code, you should copy the right code.
Attachment #235357 -
Attachment is obsolete: true
Attachment #235357 -
Flags: review?(bugs.mano)
Assignee | ||
Comment 5•18 years ago
|
||
Right, this is the version I meant to copy.
Attachment #235364 -
Flags: review?(bugs.mano)
Comment 6•18 years ago
|
||
Comment on attachment 235364 [details] [diff] [review]
Trunk patch, v.2
r=mano
Attachment #235364 -
Flags: review?(bugs.mano)
Attachment #235364 -
Flags: review+
Attachment #235364 -
Flags: approval1.8.1?
Assignee | ||
Comment 7•18 years ago
|
||
Same thing, just with the MOZILLA_1_8_BRANCH interface name.
Updated•18 years ago
|
Attachment #235364 -
Flags: approval1.8.1?
Updated•18 years ago
|
Attachment #235371 -
Flags: approval1.8.1?
Assignee | ||
Comment 8•18 years ago
|
||
To test: open the testcase, in the "open or save" dialog choose to open with any app bundle text editor, like TextEdit.app (the testcase is just a couple of words, served as application/hard-cheese), and tick the box to "always do this." In a build without this patch, when you then go to Preferences, Content, File Types, Manage..., the dialog will have an entry that reads "| CHEESE | CHEESE file | Open with |" because we try to use a file name, and the "file" TextEdit.app is actually a directory. With the patch, it will say "| Open with TextEdit |".
Assignee | ||
Comment 9•18 years ago
|
||
Drivers: risk is near zero: this is copied from the code that has been displaying feed reader applications since the end of June, and the code around the copied block was copied from this code, so it's prodigal code coming home. Right now we're utterly broken, showing "Open with " for anything the user has chosen as a helper app, and because of the way Mac plugins mostly don't register filename extensions and we hide plugins that don't register extensions, there's nothing much but what the user has chosen shown, so there's only the broken things that could possibly be broken.
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed]
Comment 10•18 years ago
|
||
Comment on attachment 235371 [details] [diff] [review]
Branch patch
a=beltzner on behalf of the 181drivers
Attachment #235371 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed] → [checkin needed][checkin needed (1.8branch)]
Comment 11•18 years ago
|
||
mozilla/browser/components/preferences/downloadactions.js 1.12
mozilla/browser/components/preferences/downloadactions.js 1.5.2.6
Status: NEW → RESOLVED
Closed: 18 years ago → 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed][checkin needed (1.8branch)]
You need to log in
before you can comment on or make changes to this bug.
Description
•