Martijn Wargers (dead) Assignee
	Description • 19 years ago

Spin-off from bug 332345.

Currently, you can see the caret when a readonly text input has focus.
This can be confusing for the user, thinking he can erase any existing text, by pressing the backspace key. 
He would then be surprised to see he is going back in history instead.

So maybe just disable the backspace key for readonly inputs now?

	Martijn Wargers (dead) Assignee
	Comment 1 • 19 years ago

This is the patch that would change that behavior.

	Mats Palmgren (inactive)
	Comment 2 • 18 years ago

Comment on attachment 217281 [details] [diff] [review]
patch

Seems reasonable.
Please put the '{' on a separate line like the surrounding code.
r=mats with that.

	Martijn Wargers (dead) Assignee
	Comment 3 • 18 years ago

> (From update of attachment 217281 [details] [diff] [review] [edit])
> Seems reasonable.
> Please put the '{' on a separate line like the surrounding code.
> r=mats with that.

Ok, done that.

	Boris Zbarsky [:bzbarsky]
	Comment 4 • 18 years ago

Comment on attachment 237320 [details] [diff] [review]
patch

Looks good!

	Martijn Wargers (dead) Assignee
	Comment 5 • 18 years ago

Checking in nsEditorEventListeners.cpp;
/cvsroot/mozilla/editor/libeditor/text/nsEditorEventListeners.cpp,v  <--  nsEdit
orEventListeners.cpp
new revision: 1.241; previous revision: 1.240
done

Checked into trunk.

	neil@parkwaycc.co.uk
	Comment 6 • 18 years ago

It's weird that backspace is handled by a key event but delete is a command...