As part of the consolidation of SeaMonkey-specific code in the suite/ directory, the pref window UI needs to be moved. I'll take this as a start and proof-of-concept for the rest of the needed UI code moves.

Here's the part of this move that can be stated in a real patch, actually just jar.mn changes. I'll attach a cvsmoves file shortly that states which files need to be moved/copied. Basically, this is plain moving/copying of everything in prefwindow into the appropriate suite/ directories. I've tested this not only with the default SeaMonkey build, but also with a --enable-ui-locale=de build where I put German locale files into the appropriate dir in /l10n and that works fine as well :)

Those are the files that need to be moved/copied - I'll open a cvs moves bug once I got reviews so I know the new locations of those files are correct.

Thanks Neil for catching the bug in that cvsmoves list!

Comment on attachment 217796 [details] [diff] [review] jar.mn changes for prefwindow move Well these obviously work.

Comment on attachment 218119 [details] [diff] [review] cvs moves for prefwindow, v2 Hmm, my make-jars.pl no worky, so it's good that I visually reviewed attachment 217798 [details] [diff] [review] too!

Do you want to move stuff like pref-themes.xul that suiterunner can't use?

(In reply to comment #6) > Do you want to move stuff like pref-themes.xul that suiterunner can't use? suiterunner abandoning that came after my patch, and I really don't want to redo my patches for everything we realize that we may abandon in the future. There's no harm done with copying it now and then cvs removing it when we're really abandoning it.

The jar.mn changes are checked in, once I know that it builds, I'll also cvs remove the old files that aren't used any more now.

Everything looks OK, the old files in xpfe/ are gone now as well.