Closed
Bug 333388
Opened 19 years ago
Closed 19 years ago
[@ nsDTDContext::Pop]
Categories
(Core :: DOM: HTML Parser, defect, P5)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: timeless, Assigned: mrbkap)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, crash)
Crash Data
Attachments
(1 file)
(deleted),
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
found by coverity i presume the second bit should null check, alternatively we should remove the earlier null check and replace it w/ an assertion
Assignee | ||
Comment 1•19 years ago
|
||
The assertion isn't necesary. Inspecting the code shows that it returns the address of mEntries[anIndex] (i.e., non-null) if anIndex < mCount. The call in question passes |mStack.mCount - 1|, so we can simply remove the null check.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•19 years ago
|
||
Attachment #217807 -
Flags: superreview?(bugmail)
Attachment #217807 -
Flags: review?(bugmail)
Attachment #217807 -
Flags: superreview?(bugmail)
Attachment #217807 -
Flags: superreview+
Attachment #217807 -
Flags: review?(bugmail)
Attachment #217807 -
Flags: review+
Assignee | ||
Comment 3•19 years ago
|
||
Fixed.
Severity: critical → minor
Status: NEW → RESOLVED
Closed: 19 years ago
Priority: -- → P5
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Updated•13 years ago
|
Crash Signature: [@ nsDTDContext::Pop]
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•