Joe Hughes Reporter
	Description • 19 years ago

Currently, the tab focus ring on Mac OS X encircles the entire tab, rather than the tab label, as Safari does and we do on other platforms.  It would fit in better with other apps if the tab focus ring encircled only the tab label.

	Håkan Waara
	Comment 2 • 19 years ago

Aaron, you OK with this change too?  I think it may actually improve accessibility.

	Aaron Leventhal
	Comment 3 • 19 years ago

Yep.

	Asaf Romano (gone) Assignee
	Comment 4 • 18 years ago

I was trying to get the outline to draw in the tab area, but it turns out to be invisible (i.e. draws "under" the background image). Kevin, Håkan,:any ideas why this wold happen?

	Håkan Waara
	Comment 6 • 18 years ago

It would be awesome to see a screenshot of that too, if possible?  Thanks!

	Håkan Waara
	Comment 8 • 18 years ago

Comment on attachment 229861 [details]
Screenshot

Would it be possible to make the focus rect wrap around the actual text (just like Safari does, in the first screenshot attached) ?

Also, the focus ring is significantly thinner than the normal one in the OS. I can understand if it's done to make it look nicer, but at the same time it may make it harder to spot for people with low vision.

	Asaf Romano (gone) Assignee
	Comment 9 • 18 years ago

Use the old size.

	Kevin Gerich
	Comment 12 • 18 years ago

Comment on attachment 229936 [details] [diff] [review]
patch

looks good

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 13 • 18 years ago

Comment on attachment 229936 [details] [diff] [review]
patch

Asaf, please go ahead and land this on the branch as well as the trunk. Can you also file a follow up bug to cover the following requests:

 - centre the focus in the tab from top to bottom
 - clip it closer to the edges of the text

	Asaf Romano (gone) Assignee
	Comment 14 • 18 years ago

trunk: mozilla/toolkit/themes/pinstripe/global/browser.css 1.11
1.8 branch: mozilla/toolkit/themes/pinstripe/global/browser.css 1.7.4.3

	Asaf Romano (gone) Assignee
	Comment 15 • 18 years ago

Filed bug 345387 on comment 13.

	Wayne Woods
	Comment 16 • 18 years ago

Nice! This makes bug 328193 pretty unimportant now, but since it's still technically a chrome bug (albeit one that's hidden by the default themes), I'll leave it open.

	Håkan Waara
	Comment 17 • 18 years ago

Nice work Mano, the new version looks great!