Closed
Bug 333784
Opened 19 years ago
Closed 19 years ago
nsLivemarkService::Init leaking nsSimpleURI references
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2 alpha2
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
(deleted),
patch
|
brettw
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
The culprit appears to be the "nsIURI ** pLivemarks" used to hold the array of URIs returned by GetPagesWithAnnotation.
Assignee | ||
Comment 1•19 years ago
|
||
On my test machine/profile, this patch stopped a leak of all 3 nsSimpleURI references when initializing the nsILivemarkService.
Attachment #218228 -
Flags: superreview?(bryner)
Attachment #218228 -
Flags: review?(brettw)
Updated•19 years ago
|
Attachment #218228 -
Flags: review?(brettw) → review+
Comment 2•19 years ago
|
||
Comment on attachment 218228 [details] [diff] [review]
Adds GetPagesWithAnnotationCOMArray method to nsIAnnotationService API and changes nsLivemarkService::Init to use it
The other option would be to NS_RELEASE each array item, but it's easy to mess that up if you ever return early. This way is better.
Attachment #218228 -
Flags: superreview?(bryner) → superreview+
Assignee | ||
Comment 3•19 years ago
|
||
Landed on branch & trunk.
Comment 4•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•