Closed
Bug 334325
Opened 19 years ago
Closed 19 years ago
Method "class nsSVGGlyphFrame::IsSelectable" does not override "class nsIFrame::IsSelectable" because type qualifiers do not match
Categories
(Core :: SVG, enhancement)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: jwatt)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
tor
:
review+
tor
:
superreview+
|
Details | Diff | Splinter Review |
can the svg method be renamed? frames aren't refcount friendly anyway, so this stuff can't really be idl friendly so there shouldn't be any frozen concerns.
|
Assignee | |
Updated•19 years ago
|
OS: Linux → All
Hardware: PC → All
|
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #218696 -
Flags: superreview?(tor)
Attachment #218696 -
Flags: review?(tor)
Since we don't actually do anything in our IsSelectable other than call the base class version, we could just remove our method.
|
|
Assignee | |
Comment 3•19 years ago
|
||
Attachment #218696 -
Attachment is obsolete: true
Attachment #218699 -
Flags: superreview?(tor)
Attachment #218699 -
Flags: review?(tor)
Attachment #218696 -
Flags: superreview?(tor)
Attachment #218696 -
Flags: review?(tor)
|
|
Assignee | |
Comment 4•19 years ago
|
||
tor, does the lack of review mean you're not happy to remove all the SVG_DEBUG_SELECTION code? I really don't mind what we do, but I thought that made sense.
Attachment #218696 -
Flags: superreview+
Attachment #218696 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #218696 -
Attachment is obsolete: false
|
|
Assignee | |
Updated•19 years ago
|
Attachment #218699 -
Attachment is obsolete: true
Attachment #218699 -
Flags: superreview?(tor)
Attachment #218699 -
Flags: review?(tor)
|
|
Assignee | |
Comment 5•19 years ago
|
||
As discussed on IRC, checked in the original patch since we may want to use this debug code at a later date.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•