Closed Bug 334417 Opened 19 years ago Closed 18 years ago

Use $(SUNBIRD_VERSION) rather than `cat /moz.../version.txt` in Makefiles

Categories

(Calendar :: General, defect)

Product:
Calendar
Component:
General
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mattwillis, Assigned: mattwillis)

Details

Attachments

(3 files)

patch A, rev0 - gives us $(SUNBIRD_VERSION)
(deleted), patch
dmosedale
: first-review+
benjamin
: second-review+
benjamin
: approval-branch-1.8.1+
Details | Diff | Splinter Review
patch B, rev0 - more $(SUNBIRD_VERSION)
(deleted), patch
dmosedale
: first-review+
benjamin
: second-review+
benjamin
: approval-branch-1.8.1+
Details | Diff | Splinter Review
patch C, rev0 - default theme now uses $(SUNBIRD_VERSION)
(deleted), patch
mvl
: first-review+
Details | Diff | Splinter Review
We'd like to be able to set Sunbird's version once, similar to Ff,Tb and Sm, and use it in various Makefiles throughout the build process. This would be useful for things such as building DOMi or Venkman, and passing it a version number for its install.rdf. Migrating our stuff to one place also means we only have to change one `cat /moz.../version.txt` in the future if we move/rename where the version is pulled from. Since this will touch various modules, I'm going to make multiple small patches so only the r/sr? folk will only have to review patches relevant to them, versus trying to grok a 200k file or something.
Status: NEW → ASSIGNED
Attachment #218750 - Flags: second-review?
Attachment #218750 - Flags: first-review?
Attachment #218750 - Flags: second-review?(benjamin)
Attachment #218750 - Flags: second-review?
Attachment #218750 - Flags: first-review?(dmose)
Attachment #218750 - Flags: first-review?
Attachment #218750 - Flags: approval-branch-1.8.1?(benjamin)
Comment on attachment 218750 [details] [diff] [review] patch A, rev0 - gives us $(SUNBIRD_VERSION) r=dmose
Attachment #218750 - Flags: first-review?(dmose) → first-review+
Attachment #218750 - Flags: second-review?(benjamin)
Attachment #218750 - Flags: second-review+
Attachment #218750 - Flags: approval-branch-1.8.1?(benjamin)
Attachment #218750 - Flags: approval-branch-1.8.1+
Attachment #218833 - Flags: second-review?(benjamin)
Attachment #218833 - Flags: first-review?(dmose)
Attachment #218833 - Flags: approval-branch-1.8.1?(benjamin)
Blocks: 267789
Comment on attachment 218833 [details] [diff] [review] patch B, rev0 - more $(SUNBIRD_VERSION) r=dmose
Attachment #218833 - Flags: first-review?(dmose) → first-review+
Attachment #218833 - Flags: second-review?(benjamin)
Attachment #218833 - Flags: second-review+
Attachment #218833 - Flags: approval-branch-1.8.1?(benjamin)
Attachment #218833 - Flags: approval-branch-1.8.1+
Patches A and B checked in on branch and trunk. Bug 267789, which relies on $(SUNBIRD_VERSION) being defined, is no longer blocked.
No longer blocks: 267789
Comment on attachment 220347 [details] [diff] [review] patch C, rev0 - default theme now uses $(SUNBIRD_VERSION) r=mvl
Attachment #220347 - Flags: first-review?(mvl) → first-review+
Whiteboard: [needs landing]
Patch C checked in on trunk and MOZILLA_1_8_BRANCH Leaving bug open for further uses
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
-> VERIFIED Will reopen if we find more places we need this
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: