Closed
Bug 334528
Opened 19 years ago
Closed 18 years ago
xulrunner-stub requires msvcrt71.dll if xulrunner is built using vc7.1
Categories
(Toolkit Graveyard :: XULRunner, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: darin.moz, Assigned: benjamin)
References
Details
Attachments
(1 file)
(deleted),
patch
|
darin.moz
:
first-review+
|
Details | Diff | Splinter Review |
xulrunner-stub requires msvcrt71.dll if xulrunner is built using vc7.1
this means that we may need to copy msvcrt71.dll around when we install xulrunner apps using "xulrunner --install-app" ... or maybe there is a better solution.
depends lists msvcp71d.dll on my debug trunk build for xulrunner-stub.exe as well. Apparently it uses this function: ?_Nomemory@std@@YAXXZ
Assignee | ||
Comment 2•19 years ago
|
||
I don't care about VC7 much, but am happy to morph this to cover VC8, which is what will be building XR 1.9.
Assignee | ||
Comment 3•18 years ago
|
||
Kill two birds with one stone. The changes to xpcom/glue/[standalone/]Makefile.in mean that anyone using the xpcomglue or xpcomglue_s libraries are not constrained into a particular CRT, because the library itself contains no directives. Then we can link the stub against the new spiffy glue library.
Assignee | ||
Comment 4•18 years ago
|
||
Note that this doesn't mean the stub actually works correctly yet when used with VC8; the manifests for the CRT are looking in the appdir instead of "next to the DLL". But that's a different bug, and I'll file it as such.
Priority: -- → P2
Target Milestone: --- → mozilla1.9alpha1
Reporter | ||
Updated•18 years ago
|
Attachment #235945 -
Flags: first-review?(darin) → first-review+
Assignee | ||
Comment 5•18 years ago
|
||
Fixed on trunk. I'm vaguely tempted to ask for this for 1.8.1, but I guess not.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
(In reply to comment #5)
> Fixed on trunk. I'm vaguely tempted to ask for this for 1.8.1, but I guess not.
>
I'd vote for it! Right now we have to ship the runtime dlls and it would be nice to get away from that. We'll probably end up taking this patch for our build.
Updated•9 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•