Robert Kaiser Reporter
	Description • 19 years ago

Currently, we're using a GUID as app ID for SeaMonkey and vendor is none or "Mozilla".
We should change the app ID to seamonkey@applications.mozilla.org and on suiterunner we should use "mozilla.org" as vendor tag.

The app ID change should happen across the board, including branches and UMO.

	James Ross
	Comment 1 • 19 years ago

Pain and death and suffering.

	:Gijs (he/him)
	Comment 2 • 19 years ago

http://lxr.mozilla.org/seamonkey/source/extensions/irc/xul/content/static.js#410
(line 428)

Grumble.

	Robert Kaiser Reporter
	Comment 3 • 19 years ago

Fixing that routine would be easy, actually, just needs one line added...

So, if UMO can understand that two app IDs are the same app (just different versions), it may be a good idea to change it for suiterunner only - else we should just stay with the sucky GUID, just like Firefox and Thunderbird have to.

The vendor tag for suiterunner should change for sure though.

	James Ross
	Comment 4 • 19 years ago

Just remember to fix it on all the branches you change the ID.

	Mark Banner (:standard8)
	Comment 5 • 19 years ago

Through various discussions we've come to the conclusion that mozilla.org is the vendor id that we should use. This will give us the following from --version:

mozilla.org SeaMonkey 1.5a, Copyright (c) 1998-2006 mozilla.org

and

.mozilla.org/seamonkey/

as the profile directory.

The patch updates the startup information for this and removes the then-obsolete comments.

	Robert Kaiser Reporter
	Comment 6 • 19 years ago

Comment on attachment 220307 [details] [diff] [review]
Change vendor id to a sane setting (checked in)

Hmm, maybe we should really use MOZ_APP_DISPLAYNAME there though...

	Mark Banner (:standard8)
	Comment 7 • 19 years ago

(In reply to comment #6)
> (From update of attachment 220307 [details] [diff] [review] [edit])
> Hmm, maybe we should really use MOZ_APP_DISPLAYNAME there though...
> 

Whilst I can see your point, I tend to agree with benjamin's comment on bug 330053: 

--- quote ---
I don't think you want to do this: this value determines the location of the
profile, which should be determined separately froma "branding" setting. (e.g.
Firefox w/o official branding still uses ~/.mozilla/firefox)
--- end quote ---

	Robert Kaiser Reporter
	Comment 8 • 19 years ago

Hmm, if someone wants to do a rebranded distribution of the suite (like Beonex used to do), I guess he'll need to look into that file anyways, so it's OK to hardcode it here...
Using different branding for offcial/unofficial like Firefox isn't my primary concern here, but as Benjamin says, it's the correct thing to do in that case as well.

And I think changing the app ID isn't worth the effort after what we've heard, so let's just call this one FIXED.