Closed
Bug 335323
Opened 19 years ago
Closed 18 years ago
Fix bookmark-properties dialog dimensions in its various modes
Categories
(Firefox :: Bookmarks & History, defect, P2)
Tracking
()
RESOLVED
FIXED
Firefox 3 alpha4
People
(Reporter: mozilla, Assigned: asaf)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
moco
:
review+
|
Details | Diff | Splinter Review |
This is work done in bug 331717, but without the non-resizability part.
Reporter | ||
Comment 1•19 years ago
|
||
Attachment #219689 -
Flags: superreview?(bugs)
Attachment #219689 -
Flags: review?(philringnalda)
Comment 2•19 years ago
|
||
Comment on attachment 219689 [details] [diff] [review]
Gives bookmark properties a smaller default width (but expands it to accommodate wide labels if necessary)
r=me for doesn't-do-anything-bad-with-huge-fontsness
Attachment #219689 -
Flags: review?(philringnalda) → review+
Comment 3•19 years ago
|
||
Comment on attachment 219689 [details] [diff] [review]
Gives bookmark properties a smaller default width (but expands it to accommodate wide labels if necessary)
sr=ben@mozilla.org
Attachment #219689 -
Flags: superreview?(bugs) → superreview+
Assignee | ||
Comment 4•18 years ago
|
||
Morphing, I will also use this bug for making the "bookmark this page" dialog non-modal on all platforms but OS X.
Assignee: nobody → mano
Priority: -- → P2
Summary: Give Bookmark Properties a smaller default size, and make the default size accommodate large button labels → Fix bookmark-properties dialog dimensions in its various modes
Target Milestone: --- → Firefox 3 alpha4
Assignee | ||
Comment 5•18 years ago
|
||
Attachment #219689 -
Attachment is obsolete: true
Attachment #259846 -
Flags: review?(sspitzer)
Comment 6•18 years ago
|
||
Comment on attachment 259846 [details] [diff] [review]
patch
asaf:
1) why the distinction between undefined and false? I don't see any of the callers (or higher) using undefined. Or is that coming in another patch for something else?
2) if we stick with returning undefined, I think we should also fix the comments around the methods that call this pseudo private method, such as:
961 * @return true if any transaction has been performed.
962 */
963 showAddFolderUI:
there are a few instance of this in utils.js where we call _showBookmarkDialog(info);
perhaps we should comment the ones that call
_showBookmarkDialog(info, true); as well, even though right now they should not be returning undefined? (but that might change one day?)
Comment 7•18 years ago
|
||
Comment on attachment 259846 [details] [diff] [review]
patch
clearing review request. chatting with mano over irc, and I think he is going to make this cleaner.
Attachment #259846 -
Flags: review?(sspitzer)
Assignee | ||
Comment 8•18 years ago
|
||
Attachment #259846 -
Attachment is obsolete: true
Attachment #260174 -
Flags: review?
Assignee | ||
Updated•18 years ago
|
Attachment #260174 -
Flags: review? → review?(sspitzer)
Comment 9•18 years ago
|
||
Comment on attachment 260174 [details] [diff] [review]
patch
r=sspitzer
Attachment #260174 -
Flags: review?(sspitzer) → review+
Assignee | ||
Comment 10•18 years ago
|
||
Checking in browser/components/places/content/bookmarkProperties.xul;
/cvsroot/mozilla/browser/components/places/content/bookmarkProperties.xul,v <-- bookmarkProperties.xul
new revision: 1.24; previous revision: 1.23
done
Checking in browser/components/places/content/utils.js;
/cvsroot/mozilla/browser/components/places/content/utils.js,v <-- utils.js
new revision: 1.29; previous revision: 1.28
done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 11•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•