Closed Bug 335772 Opened 19 years ago Closed 19 years ago

Button horkage in 3.0a1 Addons

Categories

(Toolkit :: Add-ons Manager, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ehume, Assigned: robert.strong.bugs)

References

Details

(Keywords: fixed1.8.1)

Attachments

(2 files)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060427 Minefield/3.0a1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060427 Minefield/3.0a1 With system fonts set to Large (125%), the text of certain buttons in the Addons window hangs below the bottom margin of the buttons. In particular, this happens to the top extension in the Extensions list, and both themes below the default theme in the Themes list. Reproducible: Always Steps to Reproduce: 1. Set Windows to Large font size 2. Open Addons window 3. Actual Results: Some buttons are horked Expected Results: Buttons should enlarge to fit the size of text used. See screenshots: http://img88.imageshack.us/img88/3630/extensionhork9vf.png http://img99.imageshack.us/img99/5659/themehork5qs.png
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → Trunk
This does not occur where there is a single-line description, and stretching the Extension list window to change a description from two-line to single-line dynamically fixes the problem (this work-around not tested in the Themes window).
Sounds like this will need to be fixed in XUL Widgets
Attached image Linux screenshot (deleted) —
Here's another screenshot, attached so it doesn't get lost (and it also shows the bug a bit better). Interestingly, it doesn't change between 2 and 3 lines of content, only between 1 and 2 (not that that probably helps in any way...)
Try adding the following to your userChrome.css to see if it fixes this... it did for me. .selectedButtons button { min-height: 2em !important; } If someone could tell me if this occurs on Mac OS X as well it would save me some time. Thanks
I should say it fixed it for me when I added it to extensions.css and that I haven't tested it with userChrome.css
Mike, a simple fix
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #220102 - Flags: review?(mconnor)
WFM when added to extension.css.
Comment on attachment 220102 [details] [diff] [review] simple fix (make the min height of the parent 2.1em) Received a verbal + from mconnor since he is in the office today.
Attachment #220102 - Flags: review?(mconnor) → review+
Landed on trunk
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Verbal a+ from bsmedberg... checked in on MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
So... won't this break as soon as the description gets to be 3 lines long?
Please, please mark regressions as blocking the bug that caused them. Saves a lot of trouble when looking at filing bugs on the regressions...
Blocks: 329045
*** Bug 336438 has been marked as a duplicate of this bug. ***
(In reply to comment #11) > So... won't this break as soon as the description gets to be 3 lines long? No
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: