Closed
Bug 335772
Opened 19 years ago
Closed 19 years ago
Button horkage in 3.0a1 Addons
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ehume, Assigned: robert.strong.bugs)
References
Details
(Keywords: fixed1.8.1)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060427 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060427 Minefield/3.0a1
With system fonts set to Large (125%), the text of certain buttons in the Addons window hangs below the bottom margin of the buttons.
In particular, this happens to the top extension in the Extensions list, and both themes below the default theme in the Themes list.
Reproducible: Always
Steps to Reproduce:
1. Set Windows to Large font size
2. Open Addons window
3.
Actual Results:
Some buttons are horked
Expected Results:
Buttons should enlarge to fit the size of text used.
See screenshots:
http://img88.imageshack.us/img88/3630/extensionhork9vf.png
http://img99.imageshack.us/img99/5659/themehork5qs.png
Updated•19 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → Trunk
This does not occur where there is a single-line description, and stretching the Extension list window to change a description from two-line to single-line dynamically fixes the problem (this work-around not tested in the Themes window).
Assignee | ||
Comment 2•19 years ago
|
||
Sounds like this will need to be fixed in XUL Widgets
Comment 3•19 years ago
|
||
Here's another screenshot, attached so it doesn't get lost (and it also shows the bug a bit better).
Interestingly, it doesn't change between 2 and 3 lines of content, only between 1 and 2 (not that that probably helps in any way...)
Assignee | ||
Comment 4•19 years ago
|
||
Try adding the following to your userChrome.css to see if it fixes this... it did for me.
.selectedButtons button {
min-height: 2em !important;
}
If someone could tell me if this occurs on Mac OS X as well it would save me some time. Thanks
Assignee | ||
Comment 5•19 years ago
|
||
I should say it fixed it for me when I added it to extensions.css and that I haven't tested it with userChrome.css
Assignee | ||
Comment 6•19 years ago
|
||
Mike, a simple fix
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #220102 -
Flags: review?(mconnor)
Assignee | ||
Comment 8•19 years ago
|
||
Comment on attachment 220102 [details] [diff] [review]
simple fix (make the min height of the parent 2.1em)
Received a verbal + from mconnor since he is in the office today.
Attachment #220102 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 9•19 years ago
|
||
Landed on trunk
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•19 years ago
|
||
Verbal a+ from bsmedberg... checked in on MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Comment 11•19 years ago
|
||
So... won't this break as soon as the description gets to be 3 lines long?
Comment 12•19 years ago
|
||
Please, please mark regressions as blocking the bug that caused them. Saves a lot of trouble when looking at filing bugs on the regressions...
Blocks: 329045
Comment 13•19 years ago
|
||
*** Bug 336438 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 14•19 years ago
|
||
(In reply to comment #11)
> So... won't this break as soon as the description gets to be 3 lines long?
No
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•