Closed Bug 335785 Opened 19 years ago Closed 19 years ago

wrapper reparenting leak on gmail

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1

People

(Reporter: dbaron, Assigned: dbaron)

References

(
URL
)

Details

(4 keywords, Whiteboard: [patch] regression from 333697, regression fix from 321299)

Attachments

(1 file)

patch
(deleted), patch
mrbkap
: review+
jst
: superreview+
dveditz
: approval-branch-1.8.1-
dveditz
: approval1.8.0.4-
dveditz
: approval1.8.0.5-
Details | Diff | Splinter Review
A leak in the wrapper reparenting code causes a significant leak of XPCOM objects (including numerous DOM window nsGlobalObject s) by just going to https://mail.google.com/ (when user login is remembered) and closing the browser window.
Attached patch patch (deleted) — — Splinter Review
Assignee: dbradley → dbaron
Status: NEW → ASSIGNED
Attachment #220115 - Flags: superreview?(jst)
Attachment #220115 - Flags: review?(mrbkap)
Blocks: 333697
Whiteboard: [patch]
Keywords: mlk
Comment on attachment 220115 [details] [diff] [review] patch Darnit. Thanks for finding and fixing this.
Attachment #220115 - Flags: review?(mrbkap) → review+
Comment on attachment 220115 [details] [diff] [review] patch sr=jst
Attachment #220115 - Flags: superreview?(jst) → superreview+
Fix checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Keywords: regression
Flags: blocking1.8.0.4+
Comment on attachment 220115 [details] [diff] [review] patch How many more of these are there likely to be?
Attachment #220115 - Flags: approval1.8.0.4?
Attachment #220115 - Flags: approval-branch-1.8.1?(jst)
More of what? This was a regression from a change two days before; the only other leak on at least basic uses of gmail is bug 206520.
Whiteboard: [patch] → [patch] regression from 333697, regression fix from 321299
Comment on attachment 220115 [details] [diff] [review] patch approved for 1.8.0 branch, a=dveditz for drivers
Attachment #220115 - Flags: approval1.8.0.4?
Attachment #220115 - Flags: approval1.8.0.4+
Attachment #220115 - Flags: approval-branch-1.8.1?(jst)
Attachment #220115 - Flags: approval-branch-1.8.1+
Flags: blocking1.8.0.5?
Flags: blocking1.8.0.4-
Flags: blocking1.8.0.4+
Comment on attachment 220115 [details] [diff] [review] patch Unapproving for 1.8.0.4 and moving to next release per bug 321299 comment 36
Attachment #220115 - Flags: approval1.8.0.5?
Attachment #220115 - Flags: approval1.8.0.4-
Attachment #220115 - Flags: approval1.8.0.4+
Attachment #220115 - Flags: approval-branch-1.8.1?
Attachment #220115 - Flags: approval-branch-1.8.1+
Flags: blocking1.8.0.5? → blocking1.8.0.5+
Comment on attachment 220115 [details] [diff] [review] patch Jonas says we'll get a combined branch patch for all the related regressions.
Attachment #220115 - Flags: approval1.8.0.5?
Attachment #220115 - Flags: approval1.8.0.5-
Attachment #220115 - Flags: approval-branch-1.8.1?
Attachment #220115 - Flags: approval-branch-1.8.1-
Blocks: 321299
Moving to 1.8.0.6 to follow bug 321299
Flags: blocking1.8.0.6+
Flags: blocking1.8.0.5-
Flags: blocking1.8.0.5+
If bug 321299 is blocking 1.8.1 then this should be also.
Flags: blocking1.8.1?
Flags: blocking1.8.1? → blocking1.8.1+
Target Milestone: --- → mozilla1.8.1
Jonas, was this fixed by the branch patches in bug 321299?
This was fixed with bug 321299 on the 1.8 branch.
Keywords: fixed1.8.1
I checked a combined patch into the 1.8.0 branch.
Keywords: fixed1.8.0.7
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: