Closed Bug 336050 Opened 19 years ago Closed 18 years ago

Need "Restart" button after enable/disable/uninstall of extension and theme change

Categories

(Toolkit :: Add-ons Manager, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 369075
Future

People

(Reporter: gekacheka, Unassigned)

References

Details

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060429 Mozilla Sunbird/0.3a2 There's a restart application button that appears in the extension manager dialog when installing a new extension. A restart is also needed after enabling or disabling an extension, so this button should also be available in that case. Reproducible: Always Steps to Reproduce: 1. Tools | Addons 2. Enable or disable an extension Actual Results: Enabled item says "Will be enabled when application is restarted" But there is no restart button to restart the application. (There is such a button when installing an extension) Expected Results: The Restart application button should also appear when extensions have been enabled or disabled. Workaround: close the dialog, exit the application, and find the place from where it was started before (start menu tree, directory tree, desktop icon, shell window, etc.), and start it again.
We should probably do this but I haven't decided how to best display this in the ui yet if it were added.
Severity: minor → enhancement
Also for uninstall
Summary: Need "Restart" button after enable/disable extension → Need "Restart" button after enable/disable/uninstall of extension
Dup of bug 218947?
No, that is to add a restart button on install which has been added. This is to add a restart button on enable/disable/uninstall which hasn't been added due to my not being sure how to best add it to the ui since it should be separated from the other global buttons and the get more link gets in the way of being able to do this cleanly.
Flags: blocking-firefox2?
OS: Windows 2000 → All
Hardware: PC → All
Keywords: uiwanted
Assignee: nobody → michael.wu
Flags: blocking-firefox2? → blocking-firefox2+
Whiteboard: [SWAG: 2.5d]
Target Milestone: --- → Firefox 2 beta1
Assignee: michael.wu → nobody
Whiteboard: [SWAG: 2.5d]
cc'ing beltzner so he can tell you how to do this
Target Milestone: Firefox 2 beta1 → Firefox 2 beta2
Assignee: nobody → robert.bugzilla
What would be really nifty is if clicking the restart button saves your session, restarts then restores your session while still having the change applied.
Two ways to do this: 1) when the Add-ons Manager is closed, show a dialog that asks: "Firefox needs to restart to complete your changes. If you restart now, Firefox will restart with all of your open tabs and windows just as you left them. (Restart Later) (Restart Now)" 2) as soon as one of these things is touched, add a (Restart) button over where the "Get Extensions ..." link is. There's a bug on file about moving that link into a button on the left, and this solution would block on that.
Keywords: uiwanted
Whiteboard: [at risk]
Would love to get this for FF2 - but we are past beta1 and this is really an enhancement/new feature
Flags: blocking-firefox2+ → blocking-firefox2-
Neither of the solutions seems appropriate to me. Moving the url to some other ui real estate (I've tried and nothing looks appropriate so far) or having a button that doesn't open a web page (see bug 268172) seems more appropriate. Also, bug 342655 is for the "Get Add-ons" button. Reassign -> default Target Milestone -> future
Assignee: robert.bugzilla → nobody
Whiteboard: [at risk]
Target Milestone: Firefox 2 beta2 → Future
Another possibility is to have the restart button in the add-ons notification bar. So far I like this one the best though the Install view would need some work to display properly since the only button at the bottom of that list is the restart button so the list height would be larger for that view without the button.
Summary: Need "Restart" button after enable/disable/uninstall of extension → Need "Restart" button after enable/disable/uninstall of extension and theme change
*** Bug 350017 has been marked as a duplicate of this bug. ***
This was really bugging me trying out themes with 2.0rc1, since I kept losing my session. As a band aid I've created an extension, 'Restarter' which adds the code for 'Restart Firefox' to the File menu. https://addons.mozilla.org/developers/itemoverview.php?id=3458 Mentioning it here for anyone looking for a workaround.
We don't we add the Restart button right of the Find Updates button, and just leave the link as it is? The button should be disabled when there's no need to restart. For Firefox: "Find Updates" "Restart Firefox" <a>Get Extensions</a> For Thunderbird: "Install" "Find Updates" "Restart Thunderbird" <a>Get Extensions</a>
(In reply to comment #13) > We don't we add the Restart button right of the Find Updates button, and just > leave the link as it is? The button should be disabled when there's no need to > restart. > > For Firefox: > "Find Updates" "Restart Firefox" <a>Get Extensions</a> > > For Thunderbird: > "Install" "Find Updates" "Restart Thunderbird" <a>Get Extensions</a> Because it looks poorly with 3 buttons... we'll figure this out for 3.0.
*** Bug 355867 has been marked as a duplicate of this bug. ***
Flags: blocking-firefox3?
Depends on: 369075
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
No longer depends on: 369075
Random ideas I wanted to write down instead of forgetting: - replace the "Get Extensions" link with (Restart Firefox) as soon as someone touches enable/disable/uninstall - just ditch the "Get Extensions" link, but the (Restart Firefox) button there, and add a prefpanel for "Get Extensions"
Flags: blocking-firefox3?
I can think of other times a restart button that includes saved sessions is useful. 1. Firefox has consumed so much memory that windows is swapping to disk. I find that some memory hasn't been freed even after closing all windows but one, and even all tabs but one. I can say that after I have used the browser for hours... after a restart, I have more free memory than I did before the restart. A restart with Session Saver reduces this problem's significance. A button would make it even less so. 2. I have just done some banking transactions. I now want a totally fresh browser, with no residuals hanging around. I want to keep my other tabs. I would surely use a restart button more often than I use the click feature to the "busy circle whatever" That btw has no hover bubble text. Could that be converted to becoming a restart when clicked? My Thanks go to Brian Erwin for Restarter. My advice to you Brian would be to go ahead and make a button for it, except that requires some graphics skills and software or to settle for an ugly button. :) Overriding the busy circle would not.
Bug 369075 (Add permanent button for restarting Firefox to Add-ons Mgr) is already fixed... This bug has been marked as a duplicate of that bug therefore. Will be part of Firefox 3.
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.