Closed
Bug 336214
Opened 19 years ago
Closed 17 years ago
Can't move (drag and drop) multiple bookmarks from one folder to another
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: franklin, Assigned: mwu)
References
Details
Attachments
(1 file)
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060501 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060501 Minefield/3.0a1
When two or more bookmarks are selected in Places, and then dragged to a folder, nothing happens. When I select only one of the bookarms and try to move it, it moves successfully.
Reproducible: Always
Steps to Reproduce:
1. Select multiple bookmarks
2. Drag to a folder
3.
Actual Results:
Nothing happens
Expected Results:
All bookmarks should be moved to the folder
Comment 1•19 years ago
|
||
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20060501 Minefield/3.0a1 - Build ID: 0000000000
Confirmed.
Version: unspecified → Trunk
Updated•19 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•19 years ago
|
||
WFM with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060501 Minefield/3.0a1
Comment 3•19 years ago
|
||
Linux-only, then?
Comment 4•19 years ago
|
||
*** Bug 337466 has been marked as a duplicate of this bug. ***
Comment 5•18 years ago
|
||
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a6pre) Gecko/20070613 Minefield/3.0a6pre ID:0000000000
Confirmed on OS X. I'll look into this bug..
Assignee: nobody → cyen
Updated•18 years ago
|
Flags: blocking-firefox3?
Comment 6•18 years ago
|
||
I'm not seeing on windows (like Ria reported in comment #2), but I was also seeing it on mac.
although, I was seeing that when moving multiple bookmarks, only one would get moved.
Target Milestone: --- → Firefox 3 alpha6
Comment 7•18 years ago
|
||
From controller.js ( http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/controller.js#1491 ), session.numDropItems is returning 1 by default on the mac, pointing to platform-specific widget code... here: http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsDragService.cpp#748
Comment 8•18 years ago
|
||
(In reply to comment #7)
> From controller.js (
> http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/controller.js#1491
> ), session.numDropItems is returning 1 by default on the mac, pointing to
> platform-specific widget code... here:
> http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsDragService.cpp#748
>
Actually - Adam pointed out that cocoa is now enabled on trunk ( http://lxr.mozilla.org/seamonkey/source/widget/src/cocoa/nsDragService.mm#525 )
Updated•18 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Comment 9•18 years ago
|
||
From playing with Venkman: both nsDragService::GetNumDropItems and nsDragService::GetData are having issues on OS X. If I manually change the value of "dropCount" to be 2 or 3 using Venkman, the loop pulls the same item 2 or 3 times. If I change both the value of "dropCount" and make sure to change the id + url of the "data" on one of the iterations of the loop, both items are transferred correctly.
So - it looks like when using the cocoa widget, session.getData isn't putting the right values into nsTransferable, and getNumDropItems isn't returning the correct number of elements to drag.
From spending a bit of time with Venkman in Linux, all I could see was that dropCount is getting populated correctly there, but something's going wrong later in the function.
Comment 10•18 years ago
|
||
This bug also applies to multiple DnD in Thunderbird on Mac (e.g. dragging multiple messages from the Inbox onto the "Trash" folder in the left pane), and is almost definitely a platform bug, not a front-end one. CC'ing the appropriate people
Assignee: cyen → nobody
Comment 11•18 years ago
|
||
let's keep this bug about linux, and use bug #385116 for the mac.
for linux, christine writes:
"you simply can't drag multiple items. on linux, dropCount is correctly returned."
Updated•18 years ago
|
Component: Places → Widget: Gtk
Flags: blocking-firefox3+
Product: Firefox → Core
QA Contact: places → gtk
Target Milestone: Firefox 3 alpha6 → mozilla1.9beta1
Comment 12•18 years ago
|
||
with mac, we confirmed this was a toolkit bug by debugging and also by testing tbird trunk. (see bug #385116).
can someone with linux try tbird linux on trunk?
Flags: blocking1.9?
Comment 13•18 years ago
|
||
version 3.0a1pre (20070622)
Dragging of multiple e-mail messages in Thunderbird trunk on Linux works fine for me, FWIW.
Summary: Can't move multiple bookmarks from one folder to another → Can't move (drag and drop) multiple bookmarks from one folder to another
Comment 14•18 years ago
|
||
adam, thanks for trying on trunk tbird linux.
based on your comments, this is sounding more like a places bug, and not a widget bug.
for now, bringing back to places, but we could use some help in debugging this on linux.
Component: Widget: Gtk → Places
Flags: blocking1.9?
Product: Core → Firefox
QA Contact: gtk → places
Target Milestone: mozilla1.9beta1 → ---
Updated•18 years ago
|
Flags: blocking-firefox3?
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Assignee | ||
Comment 15•17 years ago
|
||
Not sure why the first flavor should always be the correct flavor when looking in a list.. so this removes that assumption. In the case of dragging bookmarks, we need the third flavor, not the first. The cocoa DnD code iterates through all the possible flavors, so I suppose this shouldn't be too wrong.
However, I'm curious as to why the TB DnD code works and the places code doesn't.
Assignee: nobody → michael.wu
Status: NEW → ASSIGNED
Attachment #271911 -
Flags: superreview?
Attachment #271911 -
Flags: review?
Assignee | ||
Updated•17 years ago
|
Attachment #271911 -
Flags: superreview?(roc)
Attachment #271911 -
Flags: superreview?
Attachment #271911 -
Flags: review?(roc)
Attachment #271911 -
Flags: review?
Attachment #271911 -
Flags: superreview?(roc)
Attachment #271911 -
Flags: superreview+
Attachment #271911 -
Flags: review?(roc)
Attachment #271911 -
Flags: review+
Assignee | ||
Updated•17 years ago
|
Assignee: michael.wu → nobody
Status: ASSIGNED → NEW
Component: Places → Widget: Gtk
Flags: blocking-firefox3+
Product: Firefox → Core
QA Contact: places → gtk
Target Milestone: --- → mozilla1.9beta1
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → michael.wu
Flags: blocking1.9?
Assignee | ||
Comment 16•17 years ago
|
||
Checking in widget/src/gtk2/nsDragService.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsDragService.cpp,v <-- nsDragService.cpp
new revision: 1.18; previous revision: 1.17
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Flags: blocking1.9?
Updated•17 years ago
|
Flags: in-litmus?
You need to log in
before you can comment on or make changes to this bug.
Description
•