Closed Bug 336625 Opened 18 years ago Closed 18 years ago

When dragging & dropping text into search bar, it is grey, search doesn't work

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 alpha3

People

(Reporter: stevee, Assigned: Gavin)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

patch 2
(deleted), patch
mozilla
: review+
Details | Diff | Splinter Review 
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060504 Minefield/3.0a1 ID:2006050401

1. Choose a search engine and make it so the searchbar doesn't have focus, so the grey descriptive text is present ('Google Search')
2. Highlight some text and drag and drop it into the search bar

Expected:
Text is displayed in the searchbar, in black text as if the user had entered it

Actual:
Text is displayed in the searchbar, but in grey.
Severity: normal → trivial
Probably just need to reset the "empty" attribute onDrop if the dropped text is
not empty, or something like that.
OS: Windows 2000 → All
Hardware: PC → All
Status: NEW → ASSIGNED
Assignee: nobody → joe
Status: ASSIGNED → NEW
Dup of bug 128066?
(In reply to comment #2)
> Dup of bug 128066?

No, the grey text is done using focus and blur handlers, so that wouldn't really help.
Attached patch patch (obsolete) (deleted) — — Splinter Review 
Assignee: joe → gavin.sharp
Status: NEW → ASSIGNED

        Attachment #221110 -
        Flags: review?(joe)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch 2 (deleted)
        — 
          — Splinter Review
      

    


  

        Attachment #221110 -
        Attachment is obsolete: true

        Attachment #221111 -
        Flags: review?(joe)

        Attachment #221110 -
        Flags: review?(joe)
Depends on: 280635
Blocks: 336624

    
    

    
  
Comment on attachment 221111 [details] [diff] [review]
patch 2

Looks good; consider noting what the "empty" attribute signifies in the comment.

        Attachment #221111 -
        Flags: review?(joe) → review+
Whiteboard: [checkin needed]

    
    

    
  
Changed the comment to:
"Remove the search bar's empty attribute, since we're setting a value without focusing the textbox. If it's not empty, this won't do anything. This can be removed if bug 280635 is fixed."

mozilla/browser/components/search/content/search.xml 	1.54
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Summary: When draging&dropping text into search bar, it is grey → When dragging & dropping text into search bar, it is grey
Whiteboard: [checkin needed] → [checkin needed (1.8 branch)]
Target Milestone: --- → Firefox 2 beta1
Version: Trunk → 2.0 Branch

    
    

    
  
*** Bug 337804 has been marked as a duplicate of this bug. ***
Summary: When dragging & dropping text into search bar, it is grey → When dragging & dropping text into search bar, it is grey, search doesn't work

    
    

    
  
*** Bug 337256 has been marked as a duplicate of this bug. ***
No longer blocks: 337256

    
    

    
  
mozilla/browser/components/search/content/search.xml 	1.37.2.19
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: Firefox 2 beta1 → Firefox 2 alpha3

    
    

    
  
Sorry, the last checkin comment was for another bug, here's the right one:
mozilla/browser/components/search/content/search.xml 	1.37.2.20

    
    

    
  
*** Bug 338195 has been marked as a duplicate of this bug. ***

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: