Closed
Bug 336726
Opened 19 years ago
Closed 19 years ago
XUL: Non-relevant controls should not be shown
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: allan, Assigned: surkov)
References
()
Details
(Keywords: fixed1.8.0.5, fixed1.8.1)
Attachments
(2 files, 1 obsolete file)
Controls bound to non-relevant nodes should not be shown per default (like for XHTML).
|
Reporter | |
Comment 1•19 years ago
|
||
|
Assignee | |
Comment 2•19 years ago
|
||
It's pretty simple patch but I don't like a lot !important flag. The problem is style for :disabled is applied before other styles. !important solves the problem but is it right?
Attachment #221041 -
Flags: review?(allan)
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 3•19 years ago
|
||
Comment on attachment 221041 [details] [diff] [review]
patch
(In reply to comment #2)
> Created an attachment (id=221041) [edit]
> patch
>
> It's pretty simple patch but I don't like a lot !important flag. The problem is
> style for :disabled is applied before other styles. !important solves the
> problem but is it right?
No, because then it cannot be overriden by the form author.
Attachment #221041 -
Flags: review?(allan) → review-
|
|
Assignee | |
Comment 4•19 years ago
|
||
(In reply to comment #3)
> (From update of attachment 221041 [details] [diff] [review] [edit])
> (In reply to comment #2)
> > Created an attachment (id=221041) [edit]
> > patch
> >
> > It's pretty simple patch but I don't like a lot !important flag. The problem is
> > style for :disabled is applied before other styles. !important solves the
> > problem but is it right?
>
> No, because then it cannot be overriden by the form author.
>
Not quite, it can override by using '!important' flag :)
How about the such approach?
|
|
Assignee | |
Comment 5•19 years ago
|
||
Attachment #221041 -
Attachment is obsolete: true
Attachment #221560 -
Flags: review?(allan)
|
|
Reporter | |
Comment 6•19 years ago
|
||
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 221041 [details] [diff] [review] [edit] [edit])
> > (In reply to comment #2)
> > > Created an attachment (id=221041) [edit]
> > > patch
> > >
> > > It's pretty simple patch but I don't like a lot !important flag. The problem is
> > > style for :disabled is applied before other styles. !important solves the
> > > problem but is it right?
> >
> > No, because then it cannot be overriden by the form author.
> >
>
> Not quite, it can override by using '!important' flag :)
No, because I tbelieve that our agent style sheet is a "user stylesheet":
"Both author and user style sheets may contain "!important" declarations, and user "!important" rules override author "!important" rules."
[http://www.w3.org/TR/REC-CSS2/cascade.html#important-rules]
|
|
Reporter | |
Comment 7•19 years ago
|
||
Comment on attachment 221560 [details] [diff] [review]
patch2
I'm not sure I like the approach, but it's css styling. Off we go :)
r=me
Attachment #221560 -
Flags: review?(allan)
Attachment #221560 -
Flags: review?(Olli.Pettay)
Attachment #221560 -
Flags: review+
|
||
Updated•19 years ago
|
Attachment #221560 -
Flags: review?(Olli.Pettay) → review+
|
|
Reporter | |
Comment 8•19 years ago
|
||
Fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
|
|
Reporter | |
Updated•18 years ago
|
Keywords: fixed1.8.1
|
|
Reporter | |
Updated•18 years ago
|
Keywords: fixed1.8.0.5
|
|
Reporter | |
Updated•18 years ago
|
Whiteboard: xf-to-branch
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•