Closed
Bug 336758
Opened 19 years ago
Closed 19 years ago
Add pref for repressing Fx2 Session-restore Prompt
Categories
(Webtools Graveyard :: Tinderbox, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dietrich, Assigned: morgamic)
References
Details
Attachments
(2 files)
(deleted),
patch
|
rhelmer
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
Since tinderbox shuts down the app w/ SIGTERM, and the app doesn't shut down cleanly, Ts and Tp tests fail because the new session-restore prompt prevents the test from getting to page content.
I'm attaching a patch that sets a pref to disable the prompt for the tests.
We need to get this to the build boxes as soon as possible, so we can get the feature turned on in the nightlies. Please let me know what I can do to help expedite this!
Reporter | ||
Comment 1•19 years ago
|
||
Reporter | ||
Comment 2•19 years ago
|
||
needs to go in on trunk and branch, *after* the tinderboxes are updated
Attachment #221358 -
Flags: review?(mconnor)
Comment 3•19 years ago
|
||
Comment on attachment 221358 [details] [diff] [review]
sets the resume_from_crash pref default to true
r+a=me for 1.8.1 branch after the tbox changes happen
Attachment #221358 -
Flags: review?(mconnor) → review+
Comment 4•19 years ago
|
||
Comment on attachment 221358 [details] [diff] [review]
sets the resume_from_crash pref default to true
r=preed
Attachment #221358 -
Flags: review+
Comment 5•19 years ago
|
||
(In reply to comment #4)
> (From update of attachment 221358 [details] [diff] [review] [edit])
> r=preed
>
scratch that, reviewing the tbox patch
Comment 6•19 years ago
|
||
Comment on attachment 220945 [details] [diff] [review]
adds a pref to repress session-restore prompt
r=preed
Attachment #220945 -
Flags: review+
Updated•19 years ago
|
Attachment #221358 -
Flags: review+
Comment 7•19 years ago
|
||
(In reply to comment #6)
> (From update of attachment 220945 [details] [diff] [review] [edit])
> r=preed
>
This has landed, will be picked up by tinderboxes on next build:
Checking in tools/tinderbox/build-seamonkey-util.pl;
/cvsroot/mozilla/tools/tinderbox/build-seamonkey-util.pl,v <-- build-seamonkey-util.pl
new revision: 1.318; previous revision: 1.317
done
Comment 8•19 years ago
|
||
default flipped now, resolving as FIXED
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 9•19 years ago
|
||
Fixed 1.8.1 keyword required?
Updated•10 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•