Closed
Bug 336939
Opened 19 years ago
Closed 19 years ago
Extension manager passes bogus URIs to ConvertChromeURL
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: robert.strong.bugs)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
benjamin
:
review+
benjamin
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
BUILD: Current Firefox trunk build
STEPS TO REPRODUCE:
1) Load https://addons.mozilla.org/firefox/1865/
2) Install the extension
ACTUAL RESULTS:
###!!! ASSERTION: Non-chrome URI?: 'isChrome', file ../../../mozilla/chrome/src/nsChromeRegistry.cpp, line 608
EXPECTED RESULTS: No asserts.
The URI in question is https://addons.mozilla.org/images/default.png
The call to ConvertChromeURL comes from an anonymous function on line 7485 of the post-preprocessing nsExtensionManager.js. That would seem to be http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in&rev=1.193&mark=7656#7656
|
Reporter | |
Updated•19 years ago
|
Flags: blocking1.9a1?
Flags: blocking-firefox2?
|
|
Assignee | |
Comment 1•19 years ago
|
||
I believe the patch that added the code that causes the assertion was introduced in bug 286034 and not bug 329045
|
|
Assignee | |
Comment 2•19 years ago
|
||
Also prevents the use of schemes other than chrome or http and https when the item is installing.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #221137 -
Flags: review?(benjamin)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #221137 -
Attachment is obsolete: true
Attachment #221137 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 3•19 years ago
|
||
Attachment #221270 -
Flags: review?(benjamin)
|
||
Updated•19 years ago
|
Attachment #221270 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
Attachment #221270 -
Flags: approval-branch-1.8.1?(benjamin)
|
|
||
Updated•19 years ago
|
Attachment #221270 -
Flags: approval-branch-1.8.1?(benjamin) → approval-branch-1.8.1+
|
|
Assignee | |
Updated•19 years ago
|
Keywords: fixed1.8.1
|
||
Updated•19 years ago
|
Flags: blocking1.9a1?
Flags: blocking1.9a1+
Flags: blocking-firefox2?
Flags: blocking-firefox2+
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•