Closed
Bug 337368
Opened 18 years ago
Closed 18 years ago
Spelling suggestions don't appear when context menu is accessed from keyboard
Categories
(Firefox :: General, defect, P1)
Tracking
()
RESOLVED
FIXED
Firefox 2 alpha3
People
(Reporter: brettw, Assigned: brettw)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•18 years ago
|
||
This is because GetRangeParent/Offset use point, but the popup menu handling code sets refPoint on the event. Therefore, rangeParent actually references the first element in the text box. This mess has been cleaned up on trunk, which is why I thought it was fixed.
|
|
Assignee | |
Updated•18 years ago
|
Hardware: PC → All
Version: Trunk → 2.0 Branch
|
|
Assignee | |
Comment 2•18 years ago
|
||
The additions to nsLayoutUtils are copied from trunk.
Attachment #221718 -
Flags: review?(roc)
Attachment #221718 -
Flags: approval-branch-1.8.1?
|
|
Assignee | |
Updated•18 years ago
|
Attachment #221718 -
Flags: approval-branch-1.8.1? → approval-branch-1.8.1?(roc)
|
|
Assignee | |
Updated•18 years ago
|
Flags: blocking-firefox2?
I think you're not using the right frame here. The code that uses "point" expects the frame to be the result of nsEventStateManager::GetEventTarget, so you should pass that to GetEventCoordinatesForNearestView.
|
|
Assignee | |
Comment 4•18 years ago
|
||
I get the pres context from the shell, and get the event state manager from the pres context. Then I use GetEventTarget to get the frame, which I pass to GetEventCoordinatesForNearestView.
Attachment #221718 -
Attachment is obsolete: true
Attachment #221721 -
Flags: review?(roc)
Attachment #221721 -
Flags: approval-branch-1.8.1?(roc)
Attachment #221718 -
Flags: review?(roc)
Attachment #221718 -
Flags: approval-branch-1.8.1?(roc)
Comment on attachment 221721 [details] [diff] [review]
How about this?
+ nsCOMPtr<nsPresContext> context
Just make it nsPresContext*.
Also, set aEvent->point to zero or something before you do this so it's not random in case this fails.
Attachment #221721 -
Flags: superreview+
Attachment #221721 -
Flags: review?(roc)
Attachment #221721 -
Flags: review+
Attachment #221721 -
Flags: approval-branch-1.8.1?(roc)
Attachment #221721 -
Flags: approval-branch-1.8.1+
|
|
Assignee | |
Comment 6•18 years ago
|
||
Attachment #221721 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•18 years ago
|
Priority: -- → P1
Target Milestone: --- → Firefox 2 alpha3
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: check in on trunk+branch
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: check in on trunk+branch → check in on branch
|
|
Assignee | |
Comment 7•18 years ago
|
||
Fixed on branch.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: check in on branch
|
|
Assignee | |
Comment 8•18 years ago
|
||
*** Bug 336918 has been marked as a duplicate of this bug. ***
|
||
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
|
||
Comment 9•16 years ago
|
||
See bug 370436 for a possible issue with this patch....
You need to log in
before you can comment on or make changes to this bug.
Description
•