Closed Bug 337520 Opened 19 years ago Closed 19 years ago

Crash when window gets destroyed during mouseover event

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

x86
Windows XP
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: martijn.martijn, Assigned: smaug)

References

Details

(Keywords: crash, regression, testcase)

Attachments

(2 files, 1 obsolete file)

See upcoming testcase, which crashes Mozilla when moving the mouse over the iframe. It doesn't happen all the time, then reload and try again (although, it happens almost every time for me in current trunk build). I think the regression range is 2006-03-07/2006-03-08, which would make it a regression from bug 234455. However, I'm not sure since, I have more trouble getting older builds to crash and the ui in that time period was also broken for Firefox, which made it harder to test. Talkback ID: TB18545976Q nsEventStateManager::DispatchMouseEvent nsEventStateManager::NotifyMouseOver nsEventStateManager::GenerateMouseEnterExit nsEventStateManager::PreHandleEvent PresShell::HandleEventInternal PresShell::HandlePositionedEvent PresShell::HandleEvent nsViewManager::HandleEvent nsViewManager::DispatchEvent HandleEvent nsWindow::DispatchEvent nsWindow::DispatchMouseEvent
Attached file testcase (obsolete) (deleted) —
Attached file testcase (deleted) —
This one is easier to crash with.
Attachment #221652 - Attachment is obsolete: true
Attached patch proposed patch (deleted) — Splinter Review
Using event callback (this is a valid use case for it) and making sure that prescontext is alive even after event dispatch. Not exactly related to this bug, but also making sure that nsEventStateManager::DispatchMouseEvent returns a pointer to an nsIFrame which is not dead. (nsFrame::HandleEvent may kill the frame :( )
Assignee: events → Olli.Pettay
Status: NEW → ASSIGNED
Attachment #221691 - Flags: superreview?(bzbarsky)
Attachment #221691 - Flags: review?(bzbarsky)
Comment on attachment 221691 [details] [diff] [review] proposed patch Looks good.
Attachment #221691 - Flags: superreview?(bzbarsky)
Attachment #221691 - Flags: superreview+
Attachment #221691 - Flags: review?(bzbarsky)
Attachment #221691 - Flags: review+
Checking in nsEventStateManager.cpp; /cvsroot/mozilla/content/events/src/nsEventStateManager.cpp,v <-- nsEventStateManager.cpp new revision: 1.652; previous revision: 1.651 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: