Closed Bug 337541 Opened 19 years ago Closed 18 years ago

Fire UserDataHandlers for dying nodes asynchronously

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: sicking, Unassigned)

Details

Attachments

(1 file)

We currently fire the UserDataHandler for dying nodes synchronously in the destructor for nsGenericElement etc. This can be dangerous since they are often implemented in script, and we can be in an inconsistent state when firing them, possibly leading to crashes. We should either make sure that we're in a stable state such that we can deal with scripts running, or, better yet, why not fire the handlers asynchronously? There is no definition of when a node dies anyway so we can fire the handler off an event.
I second the event thing, fwiw. Just make sure to update your tree to Darin's patch first. ;)
Attached patch v1 (deleted) — Splinter Review
I'm not convinced anymore that we should call the handlers for NODE_DELETED. Anyway, here's a patch.
Bug 324871 removed NODE_DELETED calls.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WONTFIX
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: