Closed
Bug 337753
Opened 18 years ago
Closed 18 years ago
Create SVG paint server base class
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: tor, Assigned: tor)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Attachment #221837 -
Flags: review?(roc)
Could you use the new cairo group API to simplify nsSVGPatternFrame::SetupPaintServer? Another bug I guess.
This patch is missing the new nsSVGPaintServerFrame files.
Attachment #221837 -
Attachment is obsolete: true
Attachment #222185 -
Flags: review?(roc)
Attachment #221837 -
Flags: review?(roc)
Comment on attachment 222185 [details] [diff] [review]
include new files
The fact that HasFill and HasStroke have a crucial side effect --- setting up mFillServer/mStrokeServer --- should be clearly documented. Actually I think you should change the names here to something more like a verb and less like a predicate, but I can't think of a good name. So just go with the comment unless you can think of something.
Attachment #222185 -
Flags: superreview+
Attachment #222185 -
Flags: review?(roc)
Attachment #222185 -
Flags: review+
I couldn't think of a creative name, either. Checked in with a comment explaining those methods.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 6•18 years ago
|
||
*** Bug 336663 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•