Closed
Bug 338661
Opened 18 years ago
Closed 18 years ago
[session store] tabs are blank during session restoration
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2 beta2
People
(Reporter: asqueella, Assigned: zeniko)
References
Details
(Keywords: fixed1.8.1, polish)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mconnor
:
review+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
If the saved session contains many tabs (say, 10), it is apparent that session store first opens all the tabs with about:blank in them, then starts loading pages in the opened tabs.
It's fine that we don't load all the tabs at the same moment, but the "(Untitled)" tabs do look a bit unpolished.
Perhaps we could mimic the 'loading' state for those tabs. Or maybe they shouldn't just be all opened at once.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a2) Gecko/20060519 BonEcho/2.0a2
Assignee | ||
Comment 1•18 years ago
|
||
Unless the tabs shouldn't be loaded all at the start, a short period of displaying "(Untitled)" is inevitable because of about:blank being loaded in the new tabs. I still prefer this solution since the users sees from the beginning how many tabs will be restored (i.e. that all tabs were saved).
Assignee | ||
Comment 2•18 years ago
|
||
Simplified the above patch using the methods used by the tabbrowser itself (see http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#318 ). Sorry for the bugspam.
Attachment #222739 -
Attachment is obsolete: true
Attachment #222741 -
Flags: review?(mconnor)
Attachment #222739 -
Flags: review?(mconnor)
Updated•18 years ago
|
Attachment #222741 -
Flags: review?(mconnor)
Attachment #222741 -
Flags: review+
Attachment #222741 -
Flags: approval-branch-1.8.1+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed]
Updated•18 years ago
|
Target Milestone: --- → Firefox 2 beta1
Comment 3•18 years ago
|
||
mozilla/browser/components/sessionstore/src/nsSessionStore.js 1.5.2.6
mozilla/browser/components/sessionstore/src/nsSessionStore.js 1.14
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Version: unspecified → 2.0 Branch
Assignee | ||
Comment 4•18 years ago
|
||
The branch check-in caused bug 340301.
Comment 5•18 years ago
|
||
Backed out the branch patch until the patch for bug 292865 is landed.
Depends on: 292865
Keywords: fixed1.8.1
Reporter | ||
Comment 6•18 years ago
|
||
This missed beta 1.
Target Milestone: Firefox 2 beta1 → Firefox 2 beta2
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed]
Updated•18 years ago
|
Attachment #222741 -
Flags: approval-branch-1.8.1+ → approval1.8.1?
Updated•18 years ago
|
Whiteboard: [checkin needed]
Updated•18 years ago
|
Attachment #222741 -
Flags: approval1.8.1? → approval1.8.1+
Updated•18 years ago
|
Whiteboard: [checkin needed (1.8 branch)]
Comment 7•18 years ago
|
||
mozilla/browser/components/sessionstore/src/nsSessionStore.js 1.5.2.21
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Comment 8•18 years ago
|
||
look like the tabs show "Loading..." for split second then "Untitled" again and then they start loading again.
maybe about:blank didn't completed loading after all.
this fix the problem
- // mark the tabs as loading (at this point about:blank
- // has completed loading in all tabs, so it won't interfere)
+ // mark the tabs as loading
for (t = 0; t < aTabs.length; t++) {
var tab = aTabs[t]._tab;
+ tabbrowser.getBrowserForTab(tab).stop();
tab.setAttribute("busy", "true");
tabbrowser.updateIcon(tab);
tabbrowser.setTabTitleLoading(tab);
}
or maybe change in addTab to stop "about:blank" tabs to.
Assignee | ||
Comment 9•18 years ago
|
||
(In reply to comment #8)
> look like the tabs show "Loading..." for split second then "Untitled" again and
> then they start loading again.
Please file a new bug for this issue.
Comment 10•18 years ago
|
||
Y not to reopen this bug ?
Assignee | ||
Comment 11•18 years ago
|
||
(In reply to comment #10)
> Y not to reopen this bug ?
That's not how it works. The issue as filed is fixed and the patch hasn't caused severe regressions of any kind nor had to be backed out again. In this case, a follow up bug is the way to go...
You need to log in
before you can comment on or make changes to this bug.
Description
•