Closed
Bug 338876
Opened 19 years ago
Closed 19 years ago
Scriptable nsISocketProviderService returns noscript nsISocketProvider
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: jhpedemonte, Assigned: jhpedemonte)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
darin.moz
:
review+
darin.moz
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
The scriptable interface nsISocketProviderService has a single method, which returns the non-scriptable interface nsISocketProvider. There is no reason for the former interface for be scriptable, since none of the "scriptable" languages can make use of its sole method.
|
Assignee | |
Comment 1•19 years ago
|
||
|
|
Assignee | |
Updated•19 years ago
|
Flags: blocking1.9a2?
|
||
Comment 2•19 years ago
|
||
perhaps the method should be made noscript. the interface itself can still be used from script... script can call QueryInterface. we shouldn't prevent script from passing around interfaces as variables just because they don't have any scriptable methods ;-)
|
|
||
Comment 3•19 years ago
|
||
another choice would be to make nsISocketProvider scriptable and make its method noscript. that seems best to me. it increases the ability for script to handle and pass around objects of these types.
|
|
Assignee | |
Comment 4•19 years ago
|
||
Attachment #222924 -
Attachment is obsolete: true
Attachment #222932 -
Flags: review?(darin)
Attachment #222924 -
Flags: review?(darin)
|
|
||
Comment 5•19 years ago
|
||
Comment on attachment 222932 [details] [diff] [review]
patch v2
you can land this on the 1.8 branch too if you like.
Attachment #222932 -
Flags: review?(darin)
Attachment #222932 -
Flags: review+
Attachment #222932 -
Flags: approval-branch-1.8.1+
|
|
Assignee | |
Comment 6•19 years ago
|
||
Checked in to trunk and 1.8 branch. ->FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•