Stefan Sitter [:ssitter] Reporter
	Description • 18 years ago

Failure if you drag column to position after itself

After check in for Bug 330236 and Bug 330170 drag and drop of columns works now better. But if you try to drag columns to a position after itself it still fails.

Steps to Reproduce:
1. Find a tree with draggable columns 
   (e.g. event list in Sunbird or mail list in Thunderbird)
2. Drag a column and drop it before itself. 
   Example: 1 2 3 - drag column 2 to be inserted between 1 and 2 and drop
   --> Works ok
3. Drag a column and drop it after itself. 
   Example: 1 2 3 - drag column 2 to be inserted between 2 and 3 and drop
   --> Failure


Actual Results:
Even though the mouse button has been released the tree widget still shows the 'drop column here' indicator (vertical line between columns). 

Error in JavaScript console:
    Error: cols[0] has no properties
    Source File: chrome://global/content/bindings/tree.xml Line: 157

Moving 'drop column here' indicator to another position and performing a mouse click moves the initial dragged column to this position.


Expected Results:
If column is dragged to a position after itself no error should happen and the column order should not change.


Tested with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060522 Mozilla Sunbird/0.3a2+ and Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060522 Thunderbird/3.0a1

	Joey Minta
	Comment 1 • 18 years ago

*** Bug 348910 has been marked as a duplicate of this bug. ***

	Stefan Sitter [:ssitter] Reporter
	Comment 2 • 18 years ago

(In reply to comment #1)
> *** Bug 348910 has been marked as a duplicate of this bug. ***

Confirming based on dupe.

	Stefan Sitter [:ssitter] Reporter
	Comment 3 • 18 years ago

Retest with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a3pre) Gecko/20070223 Thunderbird/3.0a1 ID:2007022303 [cairo]: Issue still exists.

Error: cols[0] has no properties
Source File: chrome://global/content/bindings/tree.xml
Line: 177

	Wayne Mery (:wsmwk)
	Comment 4 • 17 years ago

the error on trunk is now ...

Error: col is null
Source File: chrome://global/content/bindings/tree.xml
Line: 165

secondary effect, the column header text label(?) changes from black to white

	Stefan Sitter [:ssitter] Reporter
	Comment 5 • 16 years ago

I can't reproduce this error anymore using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041300 Calendar/0.6a1.

Seems this was fixed by Bug 407453.