User-Agent: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060522 Minefield/3.0a1 Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060522 Minefield/3.0a1 Any attempt to use drag-and-drop in the Places window crashes Minefield. Reproducible: Always Steps to Reproduce: 1. Add a bookmark. 2. Select Bookmarks > Organize Bookmarks... to open the Places window. 3. Click and drag the newly created bookmark. Actual Results: FF crashes. Expected Results: User should be able to move bookmarks by using drag-and-drop. SC attachment follows.

Similar problem happens with Drag'n'drop of messages in email or newsgroup window of Thunderbird under BeOS.

Might not be the same cause but it is related. What I am seeing is that if I try and delete the default subscription (BBC) Minefield crashes. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060525 Minefield/3.0a1 ID:0000000000

Confirming behavior. Same problem with DND of mail entries in BeOS Thunderbird builds.

This patch fixes the crash. Could someone tell me if DND in places are a bit off for us, or if it's supposed to behave the way it does with this fix?

Comment on attachment 225043 [details] [diff] [review] fixed formatting r? I suggest we fix other DND-troubles in new bugs.

Comment on attachment 225043 [details] [diff] [review] fixed formatting r=sergei_d

Checking in mozilla/widget/src/beos/nsDragService.cpp; /cvsroot/mozilla/widget/src/beos/nsDragService.cpp,v <-- nsDragService.cpp new revision: 1.16; previous revision: 1.15 done

This fix needs to be back-ported to the 1.8.1 branch.

(In reply to comment #10) > Created an attachment (id=241962) [edit] > BeOS-only patch for 1.8.1 branch > > This fix needs to be back-ported to the 1.8.1 branch. > Note: there is no change to the patch code, only to formatting. for some reason, the old patch would not apply cleanly to branch, so I applied manually and created then new diff posted above.

Comment on attachment 241962 [details] [diff] [review] BeOS-only patch for 1.8.1 branch Code is buggy, I fixed it later in separate bug, I think it is better to create here proper code instantly. See dragRect.Set( aX, aY, aWidth, aHeight) is wrong, must be dragRect.Set( aX, aY, aX + aWidth, aY + aHeight) For exact reference look into current trunk code

This section of code taken verbatim from trunk version of beos/nsDragService.cpp. Fixes this bug on branch; includes fixes not in earlier (denied) patch.

Comment on attachment 241973 [details] [diff] [review] BeOS-only cumulative patch for 1.8.1 branch Askin branch approval - quite critical. fixes crash at DnD. Pure BeOS patch in pure BeOS folder

Comment on attachment 241973 [details] [diff] [review] BeOS-only cumulative patch for 1.8.1 branch a=beltzner on behalf of drivers for 1.8.1 branch (NPOTB)

Checking in mozilla/widget/src/beos/nsDragService.cpp; /cvsroot/mozilla/widget/src/beos/nsDragService.cpp,v <-- nsDragService.cpp new revision: 1.13.28.3; previous revision: 1.13.28.2 done