Closed Bug 339314 Opened 18 years ago Closed 18 years ago

remove the unnecessary nsMaiInterface classes

Categories

(Firefox :: Disability Access, defect)

All
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

References

Details

(Keywords: access)

Attachments

(1 file)

Attached patch patch (deleted) — Splinter Review
move CB function declarations to nsMaiInterfaceXXX.h and NOT use static; remove codes relates to nsMaiInterfaceXXX classes; remove nsIAccessibleAction.idl, we didn't implement it
Attachment #223429 - Flags: review?(aaronleventhal)
Comment on attachment 223429 [details] [diff] [review] patch Cool! r+ Nit -- no new patch necessary: for (int index = 0; index < MAI_INTERFACE_NUM; index++) ; It's a little cleaner to use NS_ARRAY_LENGTH(), then you don't need a magic value at the end. Also, as we have stated in the m.d.planning newsgroup, we're will only request sr= for checkin to trunk at the request of the reviewer, and I'm not asking for that. However, feel free to ask for an sr= or 2nd review from a colleague if it makes you more comfortable with this large change. It can be someone else on your team.
Attachment #223429 - Flags: review?(aaronleventhal) → review+
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Depends on: 339634
No longer blocks: newatk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: