Closed
Bug 339612
Opened 19 years ago
Closed 19 years ago
Implement a stub imgIDecoderObserver in content/layout to save code size
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Whiteboard: [patch])
Attachments
(1 file)
|
(deleted),
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
In bug 321054 comment 47 darin suggested implementing a stub imgIDecoderObserver implementation with all the methods empty so that the empty methods could be shared between the many implementations in content/layout. This would be a lot like the existing nsStubDocumentObserver class.
|
Assignee | |
Comment 1•19 years ago
|
||
I couldn't touch nsImageLoadingContent and nsObjectLoadingContent because they inherit from interfaces that inherit from imgIDecoderObserver rather than inheriting directly.
|
|
Assignee | |
Updated•19 years ago
|
Attachment #225680 -
Flags: superreview?(bugmail)
Attachment #225680 -
Flags: review?(bugmail)
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [patch]
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 225680 [details] [diff] [review] patch looks great, r+sr=sicking
Attachment #225680 -
Flags: superreview?(bugmail)
Attachment #225680 -
Flags: superreview+
Attachment #225680 -
Flags: review?(bugmail)
Attachment #225680 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Comment 4•19 years ago
|
||
This appears to have brought btek Tp down by about 2 ms. Yay! A bit hard to say for sure since it was followed by the patch for bug 339041 which brought it down an additional 4 or 5 ms.
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•