I saw this while testing bug 339656. This differs from branch so I'm filing this bug in case this is not intended behaviour. - Click the dropdown arrow on the right side of the location bar - Dropdown appears - Click it again - It disappears and reappears quickly (in branch the dropdown only disappears)

This changed between 1.9a1_2006031720 and 1.9a1_2006031805. http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-03-17+19%3A00&maxdate=2006-03-18+06%3A00

This works, but is really ugly. The problem is that currently, the rollup listener makes the popup disappear and after that the mousedown on the dropmarker gets fired which opens the popup again, because it noticed that the popup has been closed. This circumvents that. But a real solutions should probably consume the mousedown event, when the autocomplete popup is open for the url bar. This should not happen for autocomplete in webpages, though. Not sure how to make that happen. I tried to something similar as the combobox code is doing, but that wasn't working at all.

martin: how about use |toggleHistoryPopup| instead of |showHistoryPopup| on mouse down handler of history-dropmarker? http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/autocomplete.xml#842

Not working. I suffers from the same problem. The popup is already dropped down (because of the rollup listener) when the mousedown event gets invoked.

O.K. We should eat mouse event at rollup like combobox.

Comment on attachment 223836 [details] [diff] [review] Patch rv1.0 Sorry. This patch makes confuse between formfill and combobox.

This fixes this bug. We need additional check in nsFormFillController. Because combobox generates the mouse click event that target is itself. But actual focus is still set previous control after the rollup listener eats the mouse down event.

But the patch may interrupt the smooth focus moving by mouse. The demerit may be larger than the merit...

Comment on attachment 223860 [details] [diff] [review] Patch rv1.1 Sorry for the spam. I change my mind. We should only eats the mouse down event if the input has dropdown button. I'll create new patch tomorrow.

This patch only consume the rollup event if the input is autocomplete element. It doesn't give effect to formfill.

Comment on attachment 223936 [details] [diff] [review] Patch rv1.2 looks good for trunk, need to extend the iface on branch, of course

-> FIXED checked-in to trunk, I'll be attach the new patch for 1.8 branch.

checked-in to 1.8 branch too.