Closed
Bug 339721
Opened 18 years ago
Closed 14 years ago
gc_dump_thing doesn't handle null JSXMLNamespace::prefix
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Whiteboard: [patch])
Attachments
(1 file)
(deleted),
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
gc_dump_thing's code for the GCX_NAMESPACE case doesn't handle ns->prefix being null, which appears (from other code I've looked at that sets prefix to null) to be valid. I hit this running GC_MARK_DEBUG, with js_DumpGCHeap set, starting Mozilla. ns->uri in the case with null ns->prefix was "http://www.mozilla.org/microsummaries/0.1".
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #223822 -
Flags: review?(brendan)
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [patch]
Comment 2•18 years ago
|
||
Comment on attachment 223822 [details] [diff] [review]
patch
Sure, sorry I missed this for so long.
/be
Attachment #223822 -
Flags: review?(brendan) → review+
Comment 3•14 years ago
|
||
These bugs are all part of a search I made for js bugs that are getting lost in transit:
http://tinyurl.com/jsDeadEndBugs
They all have a review+'ed, non-obsoleted patch and are not marked fixed-in-tracemonkey or checkin-needed but have not seen any activity in 300 days. Some of these got lost simply because the assignee/patch provider never requested a checkin, or just because they were forgotten about.
Assignee | ||
Comment 4•14 years ago
|
||
This was in fact fixed as part of bug 366725
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=jsgc.c&branch=&root=/cvsroot&subdir=mozilla/js/src&command=DIFF_FRAMESET&rev1=3.204&rev2=3.205
but the code was then removed soon after.
You need to log in
before you can comment on or make changes to this bug.
Description
•