Closed
Bug 340340
Opened 18 years ago
Closed 18 years ago
balsa is orange since bug 326466 due to dropped pending exceptions
Categories
(Core :: XPConnect, defect, P1)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: Gavin, Assigned: brendan)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mrbkap
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Brendan has debugged this and is patching, he asked me to file this.
Reporter | ||
Comment 1•18 years ago
|
||
See also bug 326466 comment 126.
Assignee | ||
Comment 2•18 years ago
|
||
At least these two:
1. XPCWrappedNative::GetNewOrUsed calls the scriptable helper's PostCreate method and ignores it r.v.
2. nsGlobalWindow::RunTimeout ignores the r.v. from CallEventHandler.
Testing more, I'll patch as soon as the bloatcycle page works again.
/be
Assignee: general → brendan
Summary: balsa is orange since bug 326466 landed → balsa is orange since bug 326466 due to dropped pending exceptions
Assignee | ||
Comment 3•18 years ago
|
||
Actually, nsGlobalWindow::RunTimeout is ok, it's private to that class (protected at any rate), and called only from a timer callback (from the main event loop). So there is no way JS can be active on the JSContext it uses, and therefore the JS API will report any pending exception as it unwinds back to CallEventHandler.
I've beefed RunTimeout up with an assertion to this effect. Still not bloatcycling for some reason...
/be
Status: NEW → ASSIGNED
Component: DOM → XPConnect
Priority: -- → P1
Target Milestone: --- → mozilla1.9alpha
Reporter | ||
Updated•18 years ago
|
QA Contact: ian → xpconnect
Assignee | ||
Comment 4•18 years ago
|
||
Not seeing bloatcycle.html actually cycle, yet.
/be
Assignee | ||
Comment 5•18 years ago
|
||
mrbkap has been tracking the XPCWrappedNative::GetNewOrUsed fix in bug 326497.
/be
Assignee | ||
Comment 6•18 years ago
|
||
(In reply to comment #5)
> mrbkap has been tracking the XPCWrappedNative::GetNewOrUsed fix in bug 326497.
Rather, I've dup'ed bug 326497, in part. I'll build on mrbkap's patch as soon as he refreshes it.
/be
Depends on: 326497
Assignee | ||
Comment 7•18 years ago
|
||
This should go in ASAP to cure the orange on balsa.
I'll leave it to mrbkap to make the better nsDOMClassInfo.cpp fix that his comment describes, for bug 326497.
/be
Attachment #224382 -
Attachment is obsolete: true
Attachment #224391 -
Flags: superreview?(jst)
Attachment #224391 -
Flags: review?(mrbkap)
Assignee | ||
Comment 8•18 years ago
|
||
Fixes a botch in nsScriptLoader.cpp's patch that Blake pointed out.
/be
Attachment #224391 -
Attachment is obsolete: true
Attachment #224407 -
Flags: superreview?(jst)
Attachment #224407 -
Flags: review?(mrbkap)
Attachment #224391 -
Flags: superreview?(jst)
Attachment #224391 -
Flags: review?(mrbkap)
Comment 9•18 years ago
|
||
Comment on attachment 224407 [details] [diff] [review]
patch, v2
r=mrbkap on the parts that I didn't write. The parts that I did already have r=jst/shaver, so this really isn't patch-cest.
Attachment #224407 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 10•18 years ago
|
||
To get balsa back, I checked in with r=mrbkap.
/be
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 11•18 years ago
|
||
this checkin didn't show up on the trunk tinderboxen (they're closed anyway)
Updated•18 years ago
|
Attachment #224407 -
Flags: superreview?(jst) → superreview+
You need to log in
before you can comment on or make changes to this bug.
Description
•