Robert Kaiser Reporter
	Description • 19 years ago

Since it's up and running again properly, tpol has the following packaging failure:

---------------
copy c:/tinderbox/SeaMonkey-exp/WINNT_5.1_Depend/build/dist/inst_gre/../install/uninstall.exe c:/tinderbox/SeaMonkey-exp/WINNT_5.1_Depend/build/dist/inst_gre: No such file or directory

 Error: perl "/cygdrive/c/tinderbox/SeaMonkey-exp/WINNT_5.1_Depend/mozilla/xpinstall/packager/win_gre/makeall.pl" -objDir "c:/tinderbox/SeaMonkey-exp/WINNT_5.1_Depend/build" -stagePath "c:/tinderbox/SeaMonkey-exp/WINNT_5.1_Depend/build/stage" -distPath "c:/tinderbox/SeaMonkey-exp/WINNT_5.1_Depend/build/dist" -aurl http://ftp.mozilla.org/pub/mozilla.org/seamonkey/tinderbox-builds/tpol-trunk/windows-xpi -rurl http://ftp.mozilla.org/pub/mozilla.org/seamonkey/tinderbox-builds/tpol-trunk/windows-xpi
make[1]: *** [installer] Error 2
make[1]: Leaving directory `/cygdrive/c/tinderbox/SeaMonkey-exp/WINNT_5.1_Depend/build/xpinstall/packager/windows'
make: *** [installer] Error 2
--------------------

We (wrongly) build the new toolkit uninstaller during the build process, see http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/Makefile.in#51 - but that has been introduced by bug 307296 in January, and tpol has been green after that point.

I suspect the problem is connected to the recent switch to the NSIS installer for toolkit, but I'm not yet sure what causes this problem.
dist/install/uninstall.exe doesn't seem to exist at all after the build finishes, that's what I could find out, and a clobber doesn't help.

	Mark Banner (:standard8) Assignee
	Comment 1 • 19 years ago

Looks like this is hooked into the MOZ_XUL_APP builds, for instance see http://lxr.mozilla.org/mozilla/source/xpinstall/wizard/windows/Makefile.in#51 in addition to the toolkit link KaiRo showed earlier.

I'm guessing we'd have to swap this all around somehow if it will work with xpfe installer for toolkit builds.

I've got no idea why this wasn't being picked up before.

	Mark Banner (:standard8) Assignee
	Comment 2 • 19 years ago

Patch by Robert and myself - let suiterunner keep on building the xpfe installer for now until we get round to moving to the toolkit version.

	Robert Kaiser Reporter
	Comment 3 • 19 years ago

Comment on attachment 225774 [details] [diff] [review]
Keep Build the xpfe installer for windows and not the toolkit one

I have applied this to the suiterunner build on tpol for testing, we'll see if it turns green again with that...

	Mark Banner (:standard8) Assignee
	Comment 5 • 19 years ago

Comment on attachment 225914 [details] [diff] [review]
Keep Build the xpfe installer for windows and not the toolkit one v2

I forgot to mention, this version adds a missing brace and it has be applied locally on tpol and proven to fix the build.

	neil@parkwaycc.co.uk
	Comment 6 • 19 years ago

Comment on attachment 225914 [details] [diff] [review]
Keep Build the xpfe installer for windows and not the toolkit one v2

>+ifneq (1 ,$(MOZ_XUL_APP)$(MOZ_SUITE))
I don't claim to be a Makefile expert but the space before the comma looks odd.

	Benjamin Smedberg
	Comment 7 • 19 years ago

Comment on attachment 225914 [details] [diff] [review]
Keep Build the xpfe installer for windows and not the toolkit one v2

ifneq (1 ,$(MOZ_XUL_APP)$(MOZ_SUITE))

can't be right... ifneq() is space-sensitive AFAIK.

	Mark Banner (:standard8) Assignee
	Comment 8 • 19 years ago

Revised patch. This is the best way I can think of doing this ifdef.

	neil@parkwaycc.co.uk
	Comment 9 • 19 years ago

Comment on attachment 227052 [details] [diff] [review]
Keep Build the xpfe installer for windows and not the toolkit one v3

>+# XXX Suite still wants the xpfe installer at the moment
>+BUILD_SETUP=1
>+ifdef MOZ_XUL_APP
>+ifndef MOZ_SUITE
>+BUILD_SETUP=
>+endif
>+endif
I'd write that like this:
ifndef MOZ_XUL_APP
BUILD_SETUP=1
endif
ifdef MOZ_SUITE
BUILD_SETUP=1
endif

	Mark Banner (:standard8) Assignee
	Comment 10 • 19 years ago

Updated to the better style per Neil's comments. Carrying forward his sr.

	Mark Banner (:standard8) Assignee
	Comment 11 • 19 years ago

I've just checked this in. tpol was green since it came back again, so I don't know what fixed that. However it was still building in toolkit and not xpfe so I've checked this in anyway.

	Mark Banner (:standard8) Assignee
	Comment 12 • 19 years ago

tpol has stayed green and is now building in xpfe/wizard/windows/uninstall so this is fixed. I expect it was possibly green before due to not doing a clobber after backing out the previously locally applied patch.